From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752957AbcIORWh (ORCPT ); Thu, 15 Sep 2016 13:22:37 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34749 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbcIORW2 (ORCPT ); Thu, 15 Sep 2016 13:22:28 -0400 Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test To: Greg KH References: <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com> <20160915145131.GA26016@kroah.com> Cc: bhumirks@gmail.com, jrickertkc@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Sergio Paracuellos Message-ID: <57DAD8E0.1050306@gmail.com> Date: Thu, 15 Sep 2016 19:22:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160915145131.GA26016@kroah.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org That's true. It seems that checkpatch script is getting a false positive. Just trying to do checkpatch happy. Sorry for inconvenience. I'll be careful with Changelog stuff from now. Thanks for advice. Cheers, Sergio Paracuellos El 2016年09月15日 a las 16:51, Greg KH escribió: > On Thu, Sep 15, 2016 at 04:29:54PM +0200, Sergio Paracuellos wrote: >> Signed-off-by: Sergio Paracuellos >> --- >> drivers/staging/rts5208/rtsx_card.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/rts5208/rtsx_card.c b/drivers/staging/rts5208/rtsx_card.c >> index 9a5cd63..551e3064 100644 >> --- a/drivers/staging/rts5208/rtsx_card.c >> +++ b/drivers/staging/rts5208/rtsx_card.c >> @@ -645,7 +645,7 @@ int switch_ssc_clock(struct rtsx_chip *chip, int clk) >> dev_dbg(rtsx_dev(chip), "Switch SSC clock to %dMHz (cur_clk = %d)\n", >> clk, chip->cur_clk); >> >> - if ((clk <= 2) || (N > max_N)) { >> + if ((clk <= 2) || (max_N < N)) { > > Where is the constant? > > The original code looks fine to me... > > Also, I can't take patches where there is no changelog text, sorry. > > greg k-h >