From: Prarit Bhargava <prarit@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
"Brown, Len" <len.brown@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Rafael Aquini <aquini@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to crystal_khz whitelist
Date: Thu, 15 Sep 2016 13:48:00 -0400 [thread overview]
Message-ID: <57DADED0.4090107@redhat.com> (raw)
In-Reply-To: <20160915174346.GH5012@twins.programming.kicks-ass.net>
On 09/15/2016 01:43 PM, Peter Zijlstra wrote:
> On Thu, Sep 15, 2016 at 04:08:36PM +0000, Brown, Len wrote:
>>> + crystal_khz = 24000; /* 25.0 MHz */
>>
>> I guess I prefer no comment over an incorrect comment.
>>
>
> From this I take it it should really have been 24 MHz and it could have
> joined the existing case. I assumed (ha!) that since it had a special
> separate case the comment was correct.
AFAICT, it should be 25000. Len -- can you explicitly confirm that? The
turbostat code contains (tools/power/x86/turbostat/turbostat.c:3312)
case 0x55: /* SKX */
crystal_hz = 25000000; /* 25.0 MHz */
P.
>
prev parent reply other threads:[~2016-09-15 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 15:04 [PATCH 0/2] x86/tsc: Update tsc crystal_khz whitelist Prarit Bhargava
2016-09-15 15:04 ` [PATCH 1/2] x86,tsc: Use cpu id defines from intel-family.h Prarit Bhargava
2016-09-15 15:04 ` [PATCH 2/2] x86/tsc: Add additional Intel CPU models to crystal_khz whitelist Prarit Bhargava
2016-09-15 15:16 ` Peter Zijlstra
2016-09-15 16:08 ` Brown, Len
2016-09-15 17:43 ` Peter Zijlstra
2016-09-15 17:48 ` Prarit Bhargava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DADED0.4090107@redhat.com \
--to=prarit@redhat.com \
--cc=aquini@redhat.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).