From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752421AbcIORsK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Sep 2016 13:48:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45076 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751021AbcIORsD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Sep 2016 13:48:03 -0400
Message-ID: <57DADED0.4090107@redhat.com>
Date: Thu, 15 Sep 2016 13:48:00 -0400
From: Prarit Bhargava <prarit@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>,
        "Brown, Len" <len.brown@intel.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>,
        Rafael Aquini <aquini@redhat.com>, Andy Lutomirski <luto@kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to crystal_khz
 whitelist
References: <1473951858-28921-1-git-send-email-prarit@redhat.com> <1473951858-28921-3-git-send-email-prarit@redhat.com> <1A7043D5F58CCB44A599DFD55ED4C94846AE889E@fmsmsx115.amr.corp.intel.com> <20160915174346.GH5012@twins.programming.kicks-ass.net>
In-Reply-To: <20160915174346.GH5012@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 15 Sep 2016 17:48:02 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 09/15/2016 01:43 PM, Peter Zijlstra wrote:
> On Thu, Sep 15, 2016 at 04:08:36PM +0000, Brown, Len wrote:
>>> +			crystal_khz = 24000;	/* 25.0 MHz */
>>
>> I guess I prefer no comment over an incorrect comment.
>>
> 
> From this I take it it should really have been 24 MHz and it could have
> joined the existing case. I assumed (ha!) that since it had a special
> separate case the comment was correct.

AFAICT, it should be 25000.  Len -- can you explicitly confirm that?  The
turbostat code contains (tools/power/x86/turbostat/turbostat.c:3312)

                                case 0x55:      /* SKX */
                                        crystal_hz = 25000000;  /* 25.0 MHz */


P.

>