From: "Wangnan (F)" <wangnan0@huawei.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, <acme@kernel.org>,
<jolsa@kernel.org>, <linux-kernel@vger.kernel.org>,
<sukadev@linux.vnet.ibm.com>
Subject: Re: [PATCH] perf, tools: Handle events including .c and .o
Date: Mon, 19 Sep 2016 10:50:41 +0800 [thread overview]
Message-ID: <57DF5281.70905@huawei.com> (raw)
In-Reply-To: <20160918145603.GN3078@tassilo.jf.intel.com>
On 2016/9/18 22:56, Andi Kleen wrote:
> On Sun, Sep 18, 2016 at 06:20:04PM +0800, Wangnan (F) wrote:
>>
>> On 2016/9/18 9:02, Andi Kleen wrote:
>>> From: Andi Kleen <ak@linux.intel.com>
>>>
>>> This is a generic bug fix, but it helps with Sukadev's JSON event tree
>>> where such events can happen.
>>>
>>> Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading
>>> and then an error. This can happen for some Intel JSON events, which cannot
>>> be used.
>>>
>>> Fix the scanner to only match for .o or .c or .bpf at the end.
>>> This will prevent loading multiple BPF scripts separated with comma,
>>> but I assume this is acceptable.
>>>
>>> Cc: wangnan0@huawei.com
>>> Cc: sukadev@linux.vnet.ibm.com
>>> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>> I tested '.c' in middle of an event:
>>
>> # perf trace --event 'aaa.ccc'
>> invalid or unsupported event: 'aaa.ccc'
>> Run 'perf list' for a list of valid events
>> ...
>>
>> It is not recongnized as a BPF source.
>>
>> So could you please provide an example to show how
>> this potential bug breaks the parsing of new events?
> This is with the upcoming JSON uncore events:
>
> $ perf stat -e '{unc_p_clockticks,unc_p_power_state_occupancy.cores_c0}' -a -I 1000
> ERROR: problems with path {unc_p_clockticks,unc_p_power_state_occupancy.c: No such file or directory
> event syntax error: '{unc_p_clockticks,unc_p_power_state_occupancy.cores_c0}'
> \___ Failed to load {unc_p_clockticks,unc_p_power_state_occupancy.c from source: Error when compiling BPF scriptlet
>
> (add -v to see detail)
> Run 'perf list' for a list of valid events
>
> -Andi
I see, and your patch solve problem like this.
Tested-by: Wang Nan <wangnan0@huawei.com>
next prev parent reply other threads:[~2016-09-19 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 1:02 [PATCH] perf, tools: Handle events including .c and .o Andi Kleen
2016-09-18 9:03 ` Jiri Olsa
2016-09-18 14:52 ` Andi Kleen
2016-09-18 10:20 ` Wangnan (F)
2016-09-18 14:56 ` Andi Kleen
2016-09-19 2:50 ` Wangnan (F) [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-06 20:18 [PATCH 1/3] " Arnaldo Carvalho de Melo
2016-10-08 4:16 ` [PATCH] " Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DF5281.70905@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).