From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756008AbcIUIQJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 04:16:09 -0400
Received: from foss.arm.com ([217.140.101.70]:42056 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754016AbcIUIQH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 04:16:07 -0400
Subject: Re: [PATCH] irqdomain: correct comment for __irq_domain_add
To: Peng Fan <peng.fan@nxp.com>, tglx@linutronix.de
References: <1474436623-25705-1-git-send-email-peng.fan@nxp.com>
Cc: linux-kernel@vger.kernel.org
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <57E241C4.7010004@arm.com>
Date: Wed, 21 Sep 2016 09:16:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.7.0
MIME-Version: 1.0
In-Reply-To: <1474436623-25705-1-git-send-email-peng.fan@nxp.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21/09/16 06:43, Peng Fan wrote:
> Correct comments from "of_node" to "fwnode" according
> to function prototype.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
>  kernel/irq/irqdomain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 4752b43..8be2f3c 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -80,7 +80,7 @@ EXPORT_SYMBOL_GPL(irq_domain_free_fwnode);
>  
>  /**
>   * __irq_domain_add() - Allocate a new irq_domain data structure
> - * @of_node: optional device-tree node of the interrupt controller
> + * @fwnode: optional FW node of the interrupt controller
>   * @size: Size of linear map; 0 for radix mapping only
>   * @hwirq_max: Maximum number of interrupts supported by controller
>   * @direct_max: Maximum value of direct maps; Use ~0 for no limit; 0 for no
> 

We already have a fix for this in -next (see 545d5d6).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...