From: Dave Hansen <dave.hansen@linux.intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Rui Teng <rui.teng@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mike Kravetz <mike.kravetz@oracle.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Santhosh G <santhog4@in.ibm.com>
Subject: Re: [PATCH] memory-hotplug: Fix bad area access on dissolve_free_huge_pages()
Date: Wed, 21 Sep 2016 09:32:10 -0700 [thread overview]
Message-ID: <57E2B60A.2060200@linux.intel.com> (raw)
In-Reply-To: <20160921162715.GC24210@dhcp22.suse.cz>
On 09/21/2016 09:27 AM, Michal Hocko wrote:
> That was not my point. I wasn't very clear probably. Offlining can fail
> which shouldn't be really surprising. There might be a kernel allocation
> in the particular block which cannot be migrated so failures are to be
> expected. I just do not see how offlining in the middle of a gigantic
> page is any different from having any other unmovable allocation in a
> block. That being said, why don't we simply refuse to offline a block
> which is in the middle of a gigantic page.
Don't we want to minimize the things that can cause an offline to fail?
The code to fix it here doesn't seem too bad.
next prev parent reply other threads:[~2016-09-21 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 8:39 [PATCH] memory-hotplug: Fix bad area access on dissolve_free_huge_pages() Rui Teng
2016-09-13 17:32 ` Dave Hansen
2016-09-14 16:33 ` Rui Teng
2016-09-14 16:37 ` Dave Hansen
2016-09-16 13:58 ` Rui Teng
2016-09-16 16:25 ` Dave Hansen
2016-09-20 14:45 ` Rui Teng
2016-09-20 14:53 ` Dave Hansen
2016-09-20 15:52 ` Rui Teng
2016-09-20 17:43 ` Dave Hansen
2016-09-21 12:05 ` Michal Hocko
2016-09-21 16:04 ` Dave Hansen
2016-09-21 16:27 ` Michal Hocko
2016-09-21 16:32 ` Dave Hansen [this message]
2016-09-21 16:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E2B60A.2060200@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paul.gortmaker@windriver.com \
--cc=rui.teng@linux.vnet.ibm.com \
--cc=santhog4@in.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).