From: Daniel Borkmann <daniel@iogearbox.net>
To: David Miller <davem@davemloft.net>, eric.dumazet@gmail.com
Cc: peterz@infradead.org, riel@redhat.com, pabeni@redhat.com,
hannes@redhat.com, jbrouer@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
corbet@lwn.net
Subject: Re: [PATCH] softirq: let ksoftirqd do its job
Date: Fri, 23 Sep 2016 13:35:59 +0200 [thread overview]
Message-ID: <57E5139F.5040708@iogearbox.net> (raw)
In-Reply-To: <20160901.233913.237544263411665891.davem@davemloft.net>
On 09/02/2016 08:39 AM, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 31 Aug 2016 10:42:29 -0700
>
>> From: Eric Dumazet <edumazet@google.com>
>>
>> A while back, Paolo and Hannes sent an RFC patch adding threaded-able
>> napi poll loop support : (https://patchwork.ozlabs.org/patch/620657/)
>>
>> The problem seems to be that softirqs are very aggressive and are often
>> handled by the current process, even if we are under stress and that
>> ksoftirqd was scheduled, so that innocent threads would have more chance
>> to make progress.
>>
>> This patch makes sure that if ksoftirq is running, we let it
>> perform the softirq work.
>>
>> Jonathan Corbet summarized the issue in https://lwn.net/Articles/687617/
>>
>> Tested:
>>
>> - NIC receiving traffic handled by CPU 0
>> - UDP receiver running on CPU 0, using a single UDP socket.
>> - Incoming flood of UDP packets targeting the UDP socket.
>>
>> Before the patch, the UDP receiver could almost never get cpu cycles and
>> could only receive ~2,000 packets per second.
>>
>> After the patch, cpu cycles are split 50/50 between user application and
>> ksoftirqd/0, and we can effectively read ~900,000 packets per second,
>> a huge improvement in DOS situation. (Note that more packets are now
>> dropped by the NIC itself, since the BH handlers get less cpu cycles to
>> drain RX ring buffer)
>>
>> Since the load runs in well identified threads context, an admin can
>> more easily tune process scheduling parameters if needed.
>>
>> Reported-by: Paolo Abeni <pabeni@redhat.com>
>> Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> I'm just kind of assuming this won't go through my tree, but I can take
> it if that's what everyone agrees to.
Was this actually picked up somewhere in the mean time?
next prev parent reply other threads:[~2016-09-23 11:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4f1c4b38528762619fff1fa963de8971006c1234.1472460085.git.pabeni@redhat.com>
[not found] ` <20160831100854.23dad2d8@redhat.com>
[not found] ` <1472650472.14381.317.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <1472650688.32433.115.camel@redhat.com>
[not found] ` <1472652643.14381.320.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <20160831164216.2901190c@redhat.com>
[not found] ` <1472661956.14381.335.camel@edumazet-glaptop3.roam.corp.google.com>
2016-08-31 17:42 ` [PATCH] softirq: let ksoftirqd do its job Eric Dumazet
2016-08-31 19:40 ` Jesper Dangaard Brouer
2016-08-31 20:42 ` Eric Dumazet
2016-08-31 21:51 ` Jesper Dangaard Brouer
2016-08-31 22:27 ` Eric Dumazet
2016-08-31 22:47 ` Rick Jones
2016-08-31 23:11 ` Eric Dumazet
2016-08-31 23:29 ` Rick Jones
2016-09-01 10:38 ` Jesper Dangaard Brouer
2016-09-01 13:06 ` Eric Dumazet
2016-09-01 11:02 ` Jesper Dangaard Brouer
2016-09-01 11:11 ` Hannes Frederic Sowa
2016-09-01 11:53 ` Peter Zijlstra
2016-09-01 12:29 ` Jesper Dangaard Brouer
2016-09-01 12:38 ` Jesper Dangaard Brouer
2016-09-01 12:48 ` Peter Zijlstra
2016-09-01 13:30 ` Jesper Dangaard Brouer
2016-09-01 15:28 ` Peter Zijlstra
2016-09-02 8:35 ` Jesper Dangaard Brouer
2016-09-01 12:57 ` Eric Dumazet
2016-09-01 13:00 ` Hannes Frederic Sowa
2016-09-01 13:25 ` Eric Dumazet
2016-09-01 12:05 ` Hannes Frederic Sowa
2016-09-01 12:51 ` Eric Dumazet
2016-09-01 12:01 ` Hannes Frederic Sowa
2016-09-02 6:39 ` David Miller
2016-09-23 11:35 ` Daniel Borkmann [this message]
2016-09-23 11:53 ` Peter Zijlstra
2016-09-23 16:51 ` Jesper Dangaard Brouer
2016-09-23 21:16 ` Peter Zijlstra
2016-09-30 11:55 ` [tip:irq/core] softirq: Let " tip-bot for Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E5139F.5040708@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@redhat.com \
--cc=jbrouer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox