Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

Chen Gang
2016-09-25T13:58:01Z

Firstly, excuse me for replying late -- since I also agree, this patch
is not urgent ;-)

On 9/21/16 16:11, Michal Hocko wrote:
> On Wed 21-09-16 06:06:44, Chen Gang wrote:
>> On 9/20/16 16:09, Michal Hocko wrote:
> [...]
>
> skipping the large part of the email because I do not have a spare time
> to discuss this.
>

I agree, they are not urgent, so if we have no time on it, just leave
it.

But for me, they are still important (not urgent != not important), so
every member can continue to discuss about it, when he/she have time,
e.g. Do we have another better solving way for this issue?

>>> So what is the point of this whole exercise? Do not take me wrong, this
>>> area could see some improvements but I believe that doing int->bool
>>> change is not just the right thing to do and worth spending both your
>>> and reviewers time.
>>>
>>
>> I am not quite sure about that.
>
> Maybe you should listen to the feedback your are getting. I do not think
> I am not the first one here.
>

OK, for me, normally, when a mailing list contents 100+ members, every
feedback has not only one member (especially, we have about 10K members).

> Look, MM surely needs some man power. There are issues to be solved,
> patches to review. Doing the cleanups is really nice but there are more
> serious problems to solve first.

OK, we really need a task management, for me, we need notice about the
urgent and important. If the patch or issue is either urgent nor
important, we can just drop it.

If they are not urgent, but still important, just discuss about it when
have time, but do not forget it (I guess, quite a few of volunteers can
not for urgent things -- their time resources are not stable, e.g. me).

> If you want to help then starting
> with review would be much much more helpful and hugely appreciated. We
> are really lacking people there a _lot_.

I guess, I can try (at least, I want to try). But excuse me, in honest,
I am not quite familiar with mm, and my time resources are not stable
enough, either. So I am not quite sure I can do.

> Just generating more work for
> reviewers with something that doesn't make any real difference in the
> runtime is far less helpful IMHO.
>

For urgent things, really it is less helpful (in fact, it will generate
negative effect).

But if it is related with important things, we need discuss about it
when we have time (do not treat it as urgent thing).

For me, all issues in public header files are important, at least. When
a developer want to put or modify something in public header files, they
need think more -- since the members outside of mm may see them.

Thanks.
--
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.