[PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

[PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/usb/host/xhci-ring.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 797137e..9cf70c9 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -605,8 +605,9 @@ static void xhci_giveback_urb_in_irq(struct xhci_hcd *xhci,
 	}
 }
 
-void xhci_unmap_td_bounce_buffer(struct xhci_hcd *xhci, struct xhci_ring *ring,
-				 struct xhci_td *td)
+static void
+xhci_unmap_td_bounce_buffer(struct xhci_hcd *xhci, struct xhci_ring *ring,
+			    struct xhci_td *td)
 {
 	struct device *dev = xhci_to_hcd(xhci)->self.controller;
 	struct xhci_segment *seg = td->bounce_seg;
-- 
2.7.4

Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

[Greg KH]

On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.

Any reason you aren't using sparse for all of these 'static' functions
you are finding?  It should be easier than using 'W=1'.

thanks,

greg k-h

Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

[Arnd Bergmann]

On Friday, September 23, 2016 5:08:37 PM CEST Greg KH wrote:
> On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes]
> > 
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > so this patch marks this function with 'static'.
> 
> Any reason you aren't using sparse for all of these 'static' functions
> you are finding?  It should be easier than using 'W=1'.

It was my idea, I suggest to Baoyou to enable the warning standalone
and fix all instances he finds, so we can eventually enable it by default
for everyone. Once that is in place, we won't even need to use sparse
any more. I suspect it will take a while before all of his patches are
merged upstream, but IIRC he has sent almost all the ones needed for
an arm "allmodconfig" build now, and a lot have been accepted.

	Arnd

Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

[Mathias Nyman]

On 23.09.2016 16:46, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>   drivers/usb/host/xhci-ring.c | 5 +++--

Hi

There's a similar patch already pending, I'm sending that one
forward after rc1 is out

http://marc.info/?l=linux-usb&m=147170676714500&w=2

-Mathias