From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BC3C433E0 for ; Mon, 8 Mar 2021 05:44:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1152651F8 for ; Mon, 8 Mar 2021 05:44:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234601AbhCHFnw (ORCPT ); Mon, 8 Mar 2021 00:43:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:23519 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234459AbhCHFnh (ORCPT ); Mon, 8 Mar 2021 00:43:37 -0500 IronPort-SDR: KLv9ehSV3/gJ0l9Y2cROpynbJ75YsHDAp4QtuCg3mFl89Vi7dVBlj63kmWwqPI8Lv3IEbp7PkF zD19qsXBDtqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9916"; a="175081843" X-IronPort-AV: E=Sophos;i="5.81,231,1610438400"; d="scan'208";a="175081843" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2021 21:43:36 -0800 IronPort-SDR: NtrqViryP86Vw4W3pRl+OQyWQXdENR/3Jx1LkW4B3PmE9P/knbk5JWoec6miaBeoDoXpAjSsGX TVoNW287NJZA== X-IronPort-AV: E=Sophos;i="5.81,231,1610438400"; d="scan'208";a="402696119" Received: from sneftin-mobl.ger.corp.intel.com (HELO [10.185.168.83]) ([10.185.168.83]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2021 21:43:34 -0800 Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Fix error handling in e1000_set_d0_lplu_state_82571 To: Dinghao Liu , kjlu@umn.edu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , "David S. Miller" References: <20210228094424.7884-1-dinghao.liu@zju.edu.cn> From: "Neftin, Sasha" Message-ID: <57bae851-e735-d015-114b-aeacd602f623@intel.com> Date: Mon, 8 Mar 2021 07:43:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210228094424.7884-1-dinghao.liu@zju.edu.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/28/2021 11:44, Dinghao Liu wrote: > There is one e1e_wphy() call in e1000_set_d0_lplu_state_82571 > that we have caught its return value but lack further handling. > Check and terminate the execution flow just like other e1e_wphy() > in this function. > > Signed-off-by: Dinghao Liu > --- > drivers/net/ethernet/intel/e1000e/82571.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/intel/e1000e/82571.c b/drivers/net/ethernet/intel/e1000e/82571.c > index 88faf05e23ba..0b1e890dd583 100644 > --- a/drivers/net/ethernet/intel/e1000e/82571.c > +++ b/drivers/net/ethernet/intel/e1000e/82571.c > @@ -899,6 +899,8 @@ static s32 e1000_set_d0_lplu_state_82571(struct e1000_hw *hw, bool active) > } else { > data &= ~IGP02E1000_PM_D0_LPLU; > ret_val = e1e_wphy(hw, IGP02E1000_PHY_POWER_MGMT, data); > + if (ret_val) > + return ret_val; > /* LPLU and SmartSpeed are mutually exclusive. LPLU is used > * during Dx states where the power conservation is most > * important. During driver activity we should enable > Good for me. Acked-by: Sasha Neftin