From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, tiwai@suse.com
Subject: Re: [PATCH 2/4] ASoC: codecs: add wsa883x amplifier support
Date: Wed, 29 Jun 2022 11:42:22 -0500 [thread overview]
Message-ID: <57c8a55a-ba27-0b53-e957-657386034e52@linux.intel.com> (raw)
In-Reply-To: <c12b67b3-2024-2133-9fdb-3d90410a4501@linaro.org>
>>> +static int wsa883x_update_status(struct sdw_slave *slave,
>>> + enum sdw_slave_status status)
>>> +{
>>> + struct wsa883x_priv *wsa883x = dev_get_drvdata(&slave->dev);
>>> +
>>> + if (status == SDW_SLAVE_ATTACHED && slave->dev_num > 0)
>>
>> do you actually need to test if slave->dev_num is > 0?
>>
> Few years back I think it was you who asked me to add this check.. :-)
>
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2073074.html
Oops!
My comment was valid in general but at the bus level. With the benefit
of hindsight, I don't think this comment is valid in this callback.
update_status is either called with UNATTACHED, or with ATTACHED/ALERT
after programming dev_num to a value > 0.
It's not wrong to leave the code as is, but it's likely to be an
always-true condition.
next prev parent reply other threads:[~2022-06-29 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:06 [PATCH 0/4] ASoC: codecs: add WSA883x support Srinivas Kandagatla
2022-06-29 9:06 ` [PATCH 1/4] ASoC: dt-bindings: Add WSA883x bindings Srinivas Kandagatla
2022-06-29 9:06 ` [PATCH 2/4] ASoC: codecs: add wsa883x amplifier support Srinivas Kandagatla
2022-06-29 15:03 ` Pierre-Louis Bossart
2022-06-29 16:09 ` Srinivas Kandagatla
2022-06-29 16:42 ` Pierre-Louis Bossart [this message]
2022-06-29 9:06 ` [PATCH 3/4] ASoC: codecs: wsa883x: add control, dapm widgets and map Srinivas Kandagatla
2022-06-29 10:58 ` Mark Brown
2022-06-29 11:00 ` Srinivas Kandagatla
2022-06-29 9:06 ` [PATCH 4/4] MAINTAINERS: add ASoC Qualcomm codecs Srinivas Kandagatla
2022-06-29 14:44 ` (subset) [PATCH 0/4] ASoC: codecs: add WSA883x support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57c8a55a-ba27-0b53-e957-657386034e52@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox