From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCDBC433EF for ; Tue, 28 Jun 2022 15:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347495AbiF1Pb1 (ORCPT ); Tue, 28 Jun 2022 11:31:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347026AbiF1PbY (ORCPT ); Tue, 28 Jun 2022 11:31:24 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1EAAB60F2; Tue, 28 Jun 2022 08:31:23 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9A61153B; Tue, 28 Jun 2022 08:31:22 -0700 (PDT) Received: from [192.168.4.21] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 413043F66F; Tue, 28 Jun 2022 08:31:18 -0700 (PDT) Message-ID: <57e275bd-11c1-233a-e716-317f20139efe@arm.com> Date: Tue, 28 Jun 2022 16:31:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Vincenzo Frascino Subject: Re: [PATCH v2 net-next 4/4] time64.h: consolidate uses of PSEC_PER_NSEC To: Vladimir Oltean , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Xiaoliang Yang , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Michael Walle , Vinicius Costa Gomes , Maxim Kochetkov , Colin Foster , Richie Pearn , linux-kernel@vger.kernel.org, Andy Lutomirski , Thomas Gleixner References: <20220628145238.3247853-1-vladimir.oltean@nxp.com> <20220628145238.3247853-5-vladimir.oltean@nxp.com> Content-Language: en-US In-Reply-To: <20220628145238.3247853-5-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/22 15:52, Vladimir Oltean wrote: > Time-sensitive networking code needs to work with PTP times expressed in > nanoseconds, and with packet transmission times expressed in > picoseconds, since those would be fractional at higher than gigabit > speed when expressed in nanoseconds. > > Convert the existing uses in tc-taprio and the ocelot/felix DSA driver > to a PSEC_PER_NSEC macro. This macro is placed in include/linux/time64.h > as opposed to its relatives (PSEC_PER_SEC etc) from include/vdso/time64.h > because the vDSO library does not (yet) need/use it. > > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Cc: Vincenzo Frascino > Signed-off-by: Vladimir Oltean Reviewed-by: Vincenzo Frascino # for the vDSO parts > --- > v1->v2: > - move PSEC_PER_NSEC to include/linux/time64.h > - add missing include of linux/time.h > > drivers/net/dsa/ocelot/felix_vsc9959.c | 5 +++-- > include/linux/time64.h | 3 +++ > net/sched/sch_taprio.c | 5 +++-- > 3 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c > index 27d8b56cc21c..28bd4892c30a 100644 > --- a/drivers/net/dsa/ocelot/felix_vsc9959.c > +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include "felix.h" > > #define VSC9959_NUM_PORTS 6 > @@ -1235,7 +1236,7 @@ static void vsc9959_tas_guard_bands_update(struct ocelot *ocelot, int port) > u32 max_sdu; > > if (min_gate_len[tc] == U64_MAX /* Gate always open */ || > - min_gate_len[tc] * 1000 > needed_bit_time_ps) { > + min_gate_len[tc] * PSEC_PER_NSEC > needed_bit_time_ps) { > /* Setting QMAXSDU_CFG to 0 disables oversized frame > * dropping. > */ > @@ -1249,7 +1250,7 @@ static void vsc9959_tas_guard_bands_update(struct ocelot *ocelot, int port) > * frame, make sure to enable oversize frame dropping > * for frames larger than the smallest that would fit. > */ > - max_sdu = div_u64(min_gate_len[tc] * 1000, > + max_sdu = div_u64(min_gate_len[tc] * PSEC_PER_NSEC, > picos_per_byte); > /* A TC gate may be completely closed, which is a > * special case where all packets are oversized. > diff --git a/include/linux/time64.h b/include/linux/time64.h > index 81b9686a2079..2fb8232cff1d 100644 > --- a/include/linux/time64.h > +++ b/include/linux/time64.h > @@ -20,6 +20,9 @@ struct itimerspec64 { > struct timespec64 it_value; > }; > > +/* Parameters used to convert the timespec values: */ > +#define PSEC_PER_NSEC 1000L > + > /* Located here for timespec[64]_valid_strict */ > #define TIME64_MAX ((s64)~((u64)1 << 63)) > #define TIME64_MIN (-TIME64_MAX - 1) > diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c > index b9c71a304d39..0b941dd63d26 100644 > --- a/net/sched/sch_taprio.c > +++ b/net/sched/sch_taprio.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -176,7 +177,7 @@ static ktime_t get_interval_end_time(struct sched_gate_list *sched, > > static int length_to_duration(struct taprio_sched *q, int len) > { > - return div_u64(len * atomic64_read(&q->picos_per_byte), 1000); > + return div_u64(len * atomic64_read(&q->picos_per_byte), PSEC_PER_NSEC); > } > > /* Returns the entry corresponding to next available interval. If > @@ -551,7 +552,7 @@ static struct sk_buff *taprio_peek(struct Qdisc *sch) > static void taprio_set_budget(struct taprio_sched *q, struct sched_entry *entry) > { > atomic_set(&entry->budget, > - div64_u64((u64)entry->interval * 1000, > + div64_u64((u64)entry->interval * PSEC_PER_NSEC, > atomic64_read(&q->picos_per_byte))); > } > -- Regards, Vincenzo