From: Lu Baolu <baolu.lu@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
linux-usb@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 1/4] usb: dbc: early driver for xhci debug capability
Date: Fri, 21 Oct 2016 08:35:44 +0800 [thread overview]
Message-ID: <580962E0.4000209@linux.intel.com> (raw)
In-Reply-To: <20161020090836.GH3157@twins.programming.kicks-ass.net>
Hi Peter,
On 10/20/2016 05:08 PM, Peter Zijlstra wrote:
> On Thu, Oct 20, 2016 at 10:41:32AM +0200, Peter Zijlstra wrote:
>> I'm already only using early_printk() because regular printk() is an
>> unfixable piece of crap, and now you're making early_printk() useless
>> too.
> Note that the existing USB debug port stuff doesn't seem to have a
> single lock in. Its just polling on readl and doing writel without any
> serialization what so ever.
>
> Not that I've ever actually used it (lack of the magic cable), but it at
> least looks like it should mostly work.
>
Thank you again.
Your comments make sense to me. I will remove the lock and work
queue usages in the new version.
Best regards,
Lu Baolu
next prev parent reply other threads:[~2016-10-21 0:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 0:18 [RESEND PATCH v2 0/4] usb: early: add support for early printk through USB3 debug port Lu Baolu
2016-10-19 0:18 ` [RESEND PATCH v2 1/4] usb: dbc: early driver for xhci debug capability Lu Baolu
2016-10-19 13:09 ` Peter Zijlstra
2016-10-20 8:08 ` Lu Baolu
2016-10-20 8:41 ` Peter Zijlstra
2016-10-20 9:08 ` Peter Zijlstra
2016-10-21 0:35 ` Lu Baolu [this message]
2016-10-19 0:18 ` [RESEND PATCH v2 2/4] x86: add support for earlyprintk via USB3 debug port Lu Baolu
2016-10-19 0:18 ` [RESEND PATCH v2 3/4] usb: serial: usb_debug: add support for dbc debug device Lu Baolu
2016-10-19 0:18 ` [RESEND PATCH v2 4/4] usb: doc: add document for USB3 debug port usage Lu Baolu
2016-10-19 7:48 ` Jani Nikula
2016-10-20 5:45 ` Lu Baolu
2016-10-20 8:30 ` Jani Nikula
2016-10-21 0:39 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580962E0.4000209@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).