From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Sriram Dash <sriram.dash@nxp.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
suresh.gupta@nxp.com, felipe.balbi@linux.intel.com,
stern@rowland.harvard.edu,
Rajat Srivastava <rajat.srivastava@nxp.com>,
Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: Re: [PATCH v2] usb: xhci: Don't drive port 2.0 reset while resuming
Date: Tue, 25 Oct 2016 15:58:44 +0300 [thread overview]
Message-ID: <580F5704.7030605@linux.intel.com> (raw)
In-Reply-To: <1477392341-5942-1-git-send-email-sriram.dash@nxp.com>
On 25.10.2016 13:45, Sriram Dash wrote:
> For the USB3.0 controller, USB 2.0 reset not driven while
> port is in Resume state. So, do not program the USB 2.0 reset
> (PORTSC[PR]=1) while in Resume state.
>
> Signed-off-by: Rajat Srivastava <rajat.srivastava@nxp.com>
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> ---
What is the actual issue that you are fixing here?
Is there some device that is in resume (PLS==XDEV_RESUME) while driving reset?
I just sent a pach for increasing the resume time signaling to 40ms when clearing the
PORT_FEAT_SUSPEND.
Does that work for you?
If not, then we should look closer at why clearing the suspend does not work properly.
One issue could be that ClearPortFeature PORT_FEAT_SUSPEND does not really read or wait for
for changes in port status. It blindly sets the states based on time passed.
Or if it's after system suspend there might be something in bus_resume that is not working.
I don't think usb core tries to drive reset while port is still resuming
-Mathias
next prev parent reply other threads:[~2016-10-25 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 10:45 [PATCH v2] usb: xhci: Don't drive port 2.0 reset while resuming Sriram Dash
2016-10-25 12:58 ` Mathias Nyman [this message]
2016-10-26 12:34 ` Sriram Dash
2016-10-26 14:39 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580F5704.7030605@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=rajat.srivastava@nxp.com \
--cc=rajesh.bhagat@nxp.com \
--cc=sriram.dash@nxp.com \
--cc=stern@rowland.harvard.edu \
--cc=suresh.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).