From: Stephen Boyd <sboyd@kernel.org>
To: Jie Luo <quic_luoj@quicinc.com>,
agross@kernel.org, andersson@kernel.org, catalin.marinas@arm.com,
conor+dt@kernel.org, konrad.dybcio@linaro.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
p.zabel@pengutronix.de, robh+dt@kernel.org, will@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_srichara@quicinc.com
Subject: Re: [PATCH v6 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
Date: Thu, 14 Sep 2023 09:30:15 -0700 [thread overview]
Message-ID: <580f3934ab1171e27d785db7362c342d.sboyd@kernel.org> (raw)
In-Reply-To: <9952fa20-a27f-3240-cc49-5c5109febfc1@quicinc.com>
Quoting Jie Luo (2023-09-12 20:27:25)
>
>
> On 9/13/2023 1:18 AM, Stephen Boyd wrote:
> > Quoting Jie Luo (2023-09-12 05:07:02)
> >>
> >> and freq_tbl are necessary to this clock.
> >
> > I still don't see why the freq_tbl is necessary.
>
> Hi Stephen,
> For clk_rcg2_ops, freq_tbl is used to find the closest rate to decided
> the parent clock, the configuration of clock source and clock divider
> are saved in the freq_tbl to configure the RCG hardware register, the
> mapping of parent clock and hardware register value is decided by the
> freq_tbl for the RCG clock.
The divider is always 1. The frequency is the frequency of the parent.
The two pieces of information are already known without the frequency
table. Why is it needed?
next prev parent reply other threads:[~2023-09-14 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 9:18 [PATCH v6 0/4] add clock controller of qca8386/qca8084 Luo Jie
2023-09-01 9:18 ` [PATCH v6 1/4] clk: qcom: branch: Add clk_branch2_prepare_ops Luo Jie
2023-09-05 20:44 ` Stephen Boyd
2023-09-01 9:18 ` [PATCH v6 2/4] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions Luo Jie
2023-09-01 9:18 ` [PATCH v6 3/4] clk: qcom: common: commonize qcom_cc_really_probe Luo Jie
2023-09-05 20:45 ` Stephen Boyd
2023-09-01 9:18 ` [PATCH v6 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 Luo Jie
2023-09-05 21:36 ` Stephen Boyd
2023-09-07 8:36 ` Jie Luo
2023-09-07 22:45 ` Stephen Boyd
2023-09-08 11:10 ` Jie Luo
2023-09-11 20:11 ` Stephen Boyd
2023-09-12 12:07 ` Jie Luo
2023-09-12 17:18 ` Stephen Boyd
2023-09-13 3:27 ` Jie Luo
2023-09-14 16:30 ` Stephen Boyd [this message]
2023-09-15 9:57 ` Jie Luo
2023-09-23 11:26 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580f3934ab1171e27d785db7362c342d.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_luoj@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox