From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbcKBKol (ORCPT ); Wed, 2 Nov 2016 06:44:41 -0400 Received: from mga05.intel.com ([192.55.52.43]:34715 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbcKBKoj (ORCPT ); Wed, 2 Nov 2016 06:44:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="1079455394" Message-ID: <5819C2C7.3060700@intel.com> Date: Wed, 02 Nov 2016 18:41:11 +0800 From: Jike Song User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Kirti Wankhede CC: alex.williamson@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 03/19] vfio: Rearrange functions to get vfio_group from dev References: <1477517366-27871-1-git-send-email-kwankhede@nvidia.com> <1477517366-27871-4-git-send-email-kwankhede@nvidia.com> In-Reply-To: <1477517366-27871-4-git-send-email-kwankhede@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > This patch rearranges functions to get vfio_group from device > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I1f93262bdbab75094bc24b087b29da35ba70c4c6 > --- > drivers/vfio/vfio.c | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > index d1d70e0b011b..23bc86c1d05d 100644 > --- a/drivers/vfio/vfio.c > +++ b/drivers/vfio/vfio.c > @@ -480,6 +480,21 @@ static struct vfio_group *vfio_group_get_from_minor(int minor) > return group; > } > > +static struct vfio_group *vfio_group_get_from_dev(struct device *dev) > +{ > + struct iommu_group *iommu_group; > + struct vfio_group *group; > + > + iommu_group = iommu_group_get(dev); > + if (!iommu_group) > + return NULL; > + > + group = vfio_group_get_from_iommu(iommu_group); > + iommu_group_put(iommu_group); > + > + return group; > +} > + > /** > * Device objects - create, release, get, put, search > */ > @@ -811,16 +826,10 @@ EXPORT_SYMBOL_GPL(vfio_add_group_dev); > */ > struct vfio_device *vfio_device_get_from_dev(struct device *dev) > { > - struct iommu_group *iommu_group; > struct vfio_group *group; > struct vfio_device *device; > > - iommu_group = iommu_group_get(dev); > - if (!iommu_group) > - return NULL; > - > - group = vfio_group_get_from_iommu(iommu_group); > - iommu_group_put(iommu_group); > + group = vfio_group_get_from_dev(dev); > if (!group) > return NULL; > Reviewed-by: Jike Song -- Thanks, Jike