* [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device
@ 2016-11-03 6:48 Lu Baolu
2016-11-03 10:22 ` Sergei Shtylyov
2016-11-03 11:36 ` Mathias Nyman
0 siblings, 2 replies; 5+ messages in thread
From: Lu Baolu @ 2016-11-03 6:48 UTC (permalink / raw)
To: Mathias Nyman; +Cc: linux-usb, linux-kernel, Lu Baolu
cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is
not used any more. This patch removes it.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/usb/host/xhci-mem.c | 1 -
drivers/usb/host/xhci.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 6afe323..8102a86 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -1032,7 +1032,6 @@ int xhci_alloc_virt_device(struct xhci_hcd *xhci, int slot_id,
goto fail;
dev->num_rings_cached = 0;
- init_completion(&dev->cmd_completion);
dev->udev = udev;
/* Point to output device context in dcbaa. */
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index f945380..e2b62e0 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -997,7 +997,6 @@ struct xhci_virt_device {
int num_rings_cached;
#define XHCI_MAX_RINGS_CACHED 31
struct xhci_virt_ep eps[31];
- struct completion cmd_completion;
u8 fake_port;
u8 real_port;
struct xhci_interval_bw_table *bw_table;
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device
2016-11-03 6:48 [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device Lu Baolu
@ 2016-11-03 10:22 ` Sergei Shtylyov
2016-11-03 11:36 ` Mathias Nyman
2016-11-03 11:36 ` Mathias Nyman
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2016-11-03 10:22 UTC (permalink / raw)
To: Lu Baolu, Mathias Nyman; +Cc: linux-usb, linux-kernel
On 11/3/2016 9:48 AM, Lu Baolu wrote:
> cmd_completion in struct xhci_virt_device is legacy. With command
> strutcture and command queue introduced in xhci, cmd_completion is
Structure.
> not used any more. This patch removes it.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device
2016-11-03 6:48 [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device Lu Baolu
2016-11-03 10:22 ` Sergei Shtylyov
@ 2016-11-03 11:36 ` Mathias Nyman
1 sibling, 0 replies; 5+ messages in thread
From: Mathias Nyman @ 2016-11-03 11:36 UTC (permalink / raw)
To: Lu Baolu; +Cc: linux-usb, linux-kernel
On 03.11.2016 08:48, Lu Baolu wrote:
> cmd_completion in struct xhci_virt_device is legacy. With command
> strutcture and command queue introduced in xhci, cmd_completion is
> not used any more. This patch removes it.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/usb/host/xhci-mem.c | 1 -
> drivers/usb/host/xhci.h | 1 -
> 2 files changed, 2 deletions(-)
>
Thanks, I'll apply it.
-Mathias
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device
2016-11-03 10:22 ` Sergei Shtylyov
@ 2016-11-03 11:36 ` Mathias Nyman
2016-11-04 0:33 ` Lu Baolu
0 siblings, 1 reply; 5+ messages in thread
From: Mathias Nyman @ 2016-11-03 11:36 UTC (permalink / raw)
To: Sergei Shtylyov, Lu Baolu; +Cc: linux-usb, linux-kernel
On 03.11.2016 12:22, Sergei Shtylyov wrote:
> On 11/3/2016 9:48 AM, Lu Baolu wrote:
>
>> cmd_completion in struct xhci_virt_device is legacy. With command
>> strutcture and command queue introduced in xhci, cmd_completion is
>
> Structure.
>
I'll fix that while applying the patch, no need to resend
-Mathias
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device
2016-11-03 11:36 ` Mathias Nyman
@ 2016-11-04 0:33 ` Lu Baolu
0 siblings, 0 replies; 5+ messages in thread
From: Lu Baolu @ 2016-11-04 0:33 UTC (permalink / raw)
To: Mathias Nyman, Sergei Shtylyov; +Cc: linux-usb, linux-kernel
Hi,
On 11/03/2016 07:36 PM, Mathias Nyman wrote:
> On 03.11.2016 12:22, Sergei Shtylyov wrote:
>> On 11/3/2016 9:48 AM, Lu Baolu wrote:
>>
>>> cmd_completion in struct xhci_virt_device is legacy. With command
>>> strutcture and command queue introduced in xhci, cmd_completion is
>>
>> Structure.
>>
>
> I'll fix that while applying the patch, no need to resend
Thank you.
Best regards,
Lu Baolu
>
> -Mathias
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-04 0:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-03 6:48 [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device Lu Baolu
2016-11-03 10:22 ` Sergei Shtylyov
2016-11-03 11:36 ` Mathias Nyman
2016-11-04 0:33 ` Lu Baolu
2016-11-03 11:36 ` Mathias Nyman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).