From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757274AbcKDCWw (ORCPT <rfc822;w@1wt.eu>);
        Thu, 3 Nov 2016 22:22:52 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:13667 "EHLO
        szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753772AbcKDCWv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Nov 2016 22:22:51 -0400
Message-ID: <581BF0D0.9010400@huawei.com>
Date: Fri, 4 Nov 2016 10:22:08 +0800
From: zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: <nyc@holomorphy.com>, <n-horiguchi@ah.jp.nec.com>,
        <mike.kravetz@oracle.com>, <rientjes@google.com>,
        <hillf.zj@alibaba-inc.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [RFC PATCH] hugetlbfs: fix the hugetlbfs can not be mounted
References: <1477721311-54522-1-git-send-email-zhongjiang@huawei.com> <20161103121721.50040185d201e3aac27fd366@linux-foundation.org>
In-Reply-To: <20161103121721.50040185d201e3aac27fd366@linux-foundation.org>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.29.68]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016/11/4 3:17, Andrew Morton wrote:
> On Sat, 29 Oct 2016 14:08:31 +0800 zhongjiang <zhongjiang@huawei.com> wrote:
>
>> From: zhong jiang <zhongjiang@huawei.com>
>>
>> Since 'commit 3e89e1c5ea84 ("hugetlb: make mm and fs code explicitly non-modular")'
>> bring in the mainline. mount hugetlbfs will result in the following issue.
>>
>> mount: unknown filesystme type 'hugetlbfs'
>>
>> because previous patch remove the module_alias_fs, when we mount the fs type,
>> the caller get_fs_type can not find the filesystem.
>>
>> The patch just recover the module_alias_fs to identify the hugetlbfs.
> hm, 3e89e1c5ea84 ("hugetlb: make mm and fs code explicitly
> non-modular") was merged almost a year ago.  And you are apparently the
> first person to discover this regression.  Can you think why that is?
  when I pull the upstream patch in 4.9-rc2. I find that I cannot mount the hugetlbfs.
  but when I pull  the upstream remain patch in the next day.  I test again. it  work well.
  so I reply the mail right now,  please ignore the patch.  The detailed reason is not digged.

  I am sorry for wasting your time.

  Thanks you
  zhongjiang
>> index 4fb7b10..b63e7de 100644
>> --- a/fs/hugetlbfs/inode.c
>> +++ b/fs/hugetlbfs/inode.c
>> @@ -35,6 +35,7 @@
>>  #include <linux/security.h>
>>  #include <linux/magic.h>
>>  #include <linux/migrate.h>
>> +#include <linux/module.h>
>>  #include <linux/uio.h>
>>  
>>  #include <asm/uaccess.h>
>> @@ -1209,6 +1210,7 @@ static struct dentry *hugetlbfs_mount(struct file_system_type *fs_type,
>>  	.mount		= hugetlbfs_mount,
>>  	.kill_sb	= kill_litter_super,
>>  };
>> +MODULE_ALIAS_FS("hugetlbfs");
>>  
>>  static struct vfsmount *hugetlbfs_vfsmount[HUGE_MAX_HSTATE];
>>  
>
> .
>