public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hiep Cao Minh <cm-hiep@jinso.co.jp>
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
Cc: Chris Brandt <chris.brandt@renesas.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: rspi: avoid uninitialized variable access
Date: Thu, 10 Nov 2016 18:25:56 +0900	[thread overview]
Message-ID: <58243D24.5080302@jinso.co.jp> (raw)
In-Reply-To: <20161108134624.1905209-1-arnd@arndb.de>

Hi Arnd,

Thanks for your fixed patch.

On 11/08/2016 10:46 PM, Arnd Bergmann wrote:
> The newly introduced rspi_pio_transfer_in_or_our() function must
> take either a valid 'rx' or 'tx' pointer, and has undefined behavior
> if both are NULL, as found by 'gcc -Wmaybe-unintialized':
>
> drivers/spi/spi-rspi.c: In function 'rspi_pio_transfer_in_or_our':
> drivers/spi/spi-rspi.c:558:5: error: 'len' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Could you tell me what kind of GCC are you using?
I'd like to reproduce it on my environment, too.
I am using the Linaro's gcc of 
"gcc-linaro-arm-linux-gnueabihf-4.8-2014.04_linux".
But there is no error message like this on my environment.


Best regards,
Jinzai Solution Inc,
Hiep.

  parent reply	other threads:[~2016-11-10 10:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 13:46 [PATCH] spi: rspi: avoid uninitialized variable access Arnd Bergmann
2016-11-08 17:20 ` Chris Brandt
2016-11-08 17:40   ` Mark Brown
2016-11-08 18:35   ` Geert Uytterhoeven
2016-11-09 15:00 ` Applied "spi: rspi: avoid uninitialized variable access" to the spi tree Mark Brown
2016-11-10  9:25 ` Hiep Cao Minh [this message]
2016-11-10 10:51   ` [PATCH] spi: rspi: avoid uninitialized variable access Arnd Bergmann
2016-11-11  0:58     ` Hiep Cao Minh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58243D24.5080302@jinso.co.jp \
    --to=cm-hiep@jinso.co.jp \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=chris.brandt@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox