From: Lu Baolu <baolu.lu@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: xhci: handle endpoint error caused by TRB error
Date: Fri, 11 Nov 2016 09:56:21 +0800 [thread overview]
Message-ID: <58252545.5000006@linux.intel.com> (raw)
In-Reply-To: <1478826181-15337-1-git-send-email-baolu.lu@linux.intel.com>
Hi,
On 11/11/2016 09:03 AM, Lu Baolu wrote:
> When xHCI host sees a malformed TRB in a transfer ring,
> it will generate a transfer event with the completion
> code set to COMP_TRB_ERR (5), and sets the endpoint
> state in output endpoint context to EP_STATE_ERROR.
> The endpoint enters ERROR state as the result.
>
> XHCI specification requires that Set TR Dequeue Pointer
> Command shall be used to transition the endpoint from
> Error to Stopped state. Current xHCI driver doesn't
> clear this endpoint error, hence the successive URB
> enqueue requests will result in error messages of
> "WARN waiting for error on ep to be cleared". And the
> corresponding USB device stays in unresponsive state.
>
> This patch enhances xHCI driver on this by printing out
> the malformed TRB and clearing the endpoint Error state.
>
> Tested-by: Wang Wendy <wendy.wang@inte.com>
^^^^^
intel.com
I will correct it with a v2.
Best regards,
Lu Baolu
prev parent reply other threads:[~2016-11-11 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 1:03 [PATCH 1/1] usb: xhci: handle endpoint error caused by TRB error Lu Baolu
2016-11-11 1:56 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58252545.5000006@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).