From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965345AbcKMV13 (ORCPT ); Sun, 13 Nov 2016 16:27:29 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36580 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbcKMV1X (ORCPT ); Sun, 13 Nov 2016 16:27:23 -0500 Message-ID: <5828DAB1.9000800@gmail.com> Date: Sun, 13 Nov 2016 21:27:13 +0000 From: Sudip Mukherjee User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andrew Morton CC: linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org Subject: Re: [PATCH 1/3] pcmcia: m32r_pcc: check return from request_irq References: <1474237304-897-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1474237304-897-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 18 September 2016 11:21 PM, Sudip Mukherjee wrote: > While building m32r allmodconfig we were getting warning: > > drivers/pcmcia/m32r_pcc.c:331:2: > warning: ignoring return value of 'request_irq', > declared with attribute warn_unused_result > > request_irq() can fail and we should always be checking the result from > it. Check the result and return it to the caller. > > Signed-off-by: Sudip Mukherjee > --- Hi Andrew, A gentle ping. Regards Sudip