Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399

From: Caesar Wang <wxt@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Caesar Wang <wxt@rock-chips.com>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Elaine Zhang <zhangqing@rock-chips.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Brian Norris <briannorris@chromium.org>,
	Ziyuan Xu <xzy.xu@rock-chips.com>,
	Will Deacon <will.deacon@arm.com>,
	Douglas Anderson <dianders@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	tfiga@chromium.org,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	eddie.cai@rock-chips.com, linux-arm-kernel@lists.infradead.org,
	David Wu <david.wu@rock-chips.com>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399
Date: Mon, 14 Nov 2016 23:01:27 +0800	[thread overview]
Message-ID: <5829D1C7.9020105@rock-chips.com> (raw)
In-Reply-To: <2342292.tK2jqRKrXH@phil>

On 2016年11月14日 22:45, Heiko Stuebner wrote:
> Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang:
>> From: Ziyuan Xu <xzy.xu@rock-chips.com>
>>
>> Control power domain for eMMC via genpd to reduce power consumption.
>>
>> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Authorship / Signed-off mismatch. From above suggest Ziyuan is the author
> while first Signed-off-by indicates Elaine as author. Please clarify.

I believe the Elaine is the first author. Sorry for this kind of 
question to brother you again. :(

-
Caesar
>
> Thanks
> Heiko
>
>> ---
>>
>> Changes in v2:
>> - Reviewed-on: https://chromium-review.googlesource.com/376558
>> - Verified on ChromeOS kernel4.4
>>
>>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -269,6 +269,7 @@
>>   		#clock-cells = <0>;
>>   		phys = <&emmc_phy>;
>>   		phy-names = "phy_arasan";
>> +		power-domains = <&power RK3399_PD_EMMC>;
>>   		status = "disabled";
>>   	};
>>
>> @@ -690,6 +691,11 @@
>>   		status = "disabled";
>>   	};
>>
>> +	qos_emmc: qos@ffa58000 {
>> +		compatible = "syscon";
>> +		reg = <0x0 0xffa58000 0x0 0x20>;
>> +	};
>> +
>>   	qos_gmac: qos@ffa5c000 {
>>   		compatible = "syscon";
>>   		reg = <0x0 0xffa5c000 0x0 0x20>;
>> @@ -823,6 +829,11 @@
>>   			};
>>
>>   			/* These power domains are grouped by VD_LOGIC */
>> +			pd_emmc@RK3399_PD_EMMC {
>> +				reg = <RK3399_PD_EMMC>;
>> +				clocks = <&cru ACLK_EMMC>;
>> +				pm_qos = <&qos_emmc>;
>> +			};
>>   			pd_gmac@RK3399_PD_GMAC {
>>   				reg = <RK3399_PD_GMAC>;
>>   				clocks = <&cru ACLK_GMAC>;
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

-- 
caesar wang | software engineer | wxt@rock-chip.com