* [PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results
@ 2016-10-24 12:24 Vaishali Thakkar
2016-10-24 12:19 ` [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules Vaishali Thakkar
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Vaishali Thakkar @ 2016-10-24 12:24 UTC (permalink / raw)
To: mmarek
Cc: julia.lawall, gilles.muller, nicolas.palix, cocci, linux-kernel,
lars, Vaishali Thakkar
Few changes to improve the results given by the irqf_oneshot.cocci:
- Change in the matching rules to eliminate false postives in the
patch mode
- Change in the context mode to eliminate false postives in the
context mode
- Support for the missing devm_request_threaded_irq in context, report
and org mode
Changes since v2:
- Add missing initialization of metavariables
Changes since v1:
- Split patch in to the patchset
Vaishali Thakkar (3):
Coccinelle: misc: Improve the matching of rules
Coccinelle: misc: Improve the result given by context mode
Coccinelle: misc: Add support for devm variant in all modes
scripts/coccinelle/misc/irqf_oneshot.cocci | 45 ++++++++++++++++++++++++------
1 file changed, 37 insertions(+), 8 deletions(-)
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules 2016-10-24 12:24 [PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results Vaishali Thakkar @ 2016-10-24 12:19 ` Vaishali Thakkar 2016-11-12 18:06 ` Julia Lawall 2016-10-24 12:23 ` [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode Vaishali Thakkar 2016-10-24 12:24 ` [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes Vaishali Thakkar 2 siblings, 1 reply; 8+ messages in thread From: Vaishali Thakkar @ 2016-10-24 12:19 UTC (permalink / raw) To: mmarek Cc: julia.lawall, gilles.muller, nicolas.palix, cocci, linux-kernel, lars, Vaishali Thakkar Currently because of the left associativity of the operators, pattern IRQF_ONESHOT | flags does not match with the pattern when we have more than one flag after the disjunction. This eventually results in giving false positives by the script. This patch eliminates these FPs by improving the rule. Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> --- Changes since v2: - No change in this patch Changes since v1: - Splitted patch in the patchset --- scripts/coccinelle/misc/irqf_oneshot.cocci | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci index b421150..a8537fb 100644 --- a/scripts/coccinelle/misc/irqf_oneshot.cocci +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci @@ -18,13 +18,12 @@ virtual report expression dev; expression irq; expression thread_fn; -expression flags; position p; @@ ( request_threaded_irq@p(irq, NULL, thread_fn, ( -flags | IRQF_ONESHOT +IRQF_ONESHOT | ... | IRQF_ONESHOT ) @@ -32,20 +31,39 @@ IRQF_ONESHOT | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ( -flags | IRQF_ONESHOT +IRQF_ONESHOT | ... | IRQF_ONESHOT ) , ...) ) -@depends on patch@ +@r2@ expression dev; expression irq; expression thread_fn; expression flags; +expression ret; position p != r1.p; @@ +flags = IRQF_ONESHOT | ...; +( +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); +| +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); +| +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); +| +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); +) + +@depends on patch@ +expression dev; +expression irq; +expression thread_fn; +expression flags; +position p != {r1.p,r2.p}; +@@ ( request_threaded_irq@p(irq, NULL, thread_fn, ( @@ -69,13 +87,13 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ) @depends on context@ -position p != r1.p; +position p != {r1.p,r2.p}; @@ *request_threaded_irq@p(...) @match depends on report || org@ expression irq; -position p != r1.p; +position p != {r1.p,r2.p}; @@ request_threaded_irq@p(irq, NULL, ...) -- 2.1.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules 2016-10-24 12:19 ` [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules Vaishali Thakkar @ 2016-11-12 18:06 ` Julia Lawall 2016-11-18 11:22 ` Vaishali Thakkar 0 siblings, 1 reply; 8+ messages in thread From: Julia Lawall @ 2016-11-12 18:06 UTC (permalink / raw) To: Vaishali Thakkar Cc: mmarek, Gilles Muller, nicolas.palix, cocci, linux-kernel, lars On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > Currently because of the left associativity of the operators, pattern > IRQF_ONESHOT | flags does not match with the pattern when we have more > than one flag after the disjunction. This eventually results in giving > false positives by the script. This patch eliminates these FPs by > improving the rule. > > Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> > --- > Changes since v2: > - No change in this patch > Changes since v1: > - Splitted patch in the patchset > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 30 ++++++++++++++++++++++++------ > 1 file changed, 24 insertions(+), 6 deletions(-) > > diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci > index b421150..a8537fb 100644 > --- a/scripts/coccinelle/misc/irqf_oneshot.cocci > +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci > @@ -18,13 +18,12 @@ virtual report > expression dev; > expression irq; > expression thread_fn; > -expression flags; > position p; > @@ > ( > request_threaded_irq@p(irq, NULL, thread_fn, > ( > -flags | IRQF_ONESHOT > +IRQF_ONESHOT | ... > | > IRQF_ONESHOT > ) > @@ -32,20 +31,39 @@ IRQF_ONESHOT > | > devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > ( > -flags | IRQF_ONESHOT > +IRQF_ONESHOT | ... > | > IRQF_ONESHOT > ) > , ...) > ) > > -@depends on patch@ > +@r2@ > expression dev; > expression irq; > expression thread_fn; > expression flags; > +expression ret; > position p != r1.p; > @@ > +flags = IRQF_ONESHOT | ...; > +( > +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); > +| > +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); > +| > +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); > +| > +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); > +) This rule needs some improvement. flags = IRQF_ONESHOT | ...; should be replaced by: ( flags = IRQF_ONESHOT | ... | flags |= IRQF_ONESHOT | ... ) ... when != flags = e where e should be a new expression metavariable. This effects a number of changes. 1) Dropping the ; after the assignment allows an isomorphism to trigger that allows it to match a variable declaration as well, 2) IRQF_ONESHOT can be added after the original initialization by a |=, 3) there can be some instructions between the initialization of flags and the use. Afterwards, the big disjunction with the irq calls is too specific. In particular, these calls can also occur in an if test. The disjunction should be replaced by the following: ( request_threaded_irq@p(irq, NULL, thread_fn, flags, ...) | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...) ) julia > + > +@depends on patch@ > +expression dev; > +expression irq; > +expression thread_fn; > +expression flags; > +position p != {r1.p,r2.p}; > +@@ > ( > request_threaded_irq@p(irq, NULL, thread_fn, > ( > @@ -69,13 +87,13 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > ) > > @depends on context@ > -position p != r1.p; > +position p != {r1.p,r2.p}; > @@ > *request_threaded_irq@p(...) > > @match depends on report || org@ > expression irq; > -position p != r1.p; > +position p != {r1.p,r2.p}; > @@ > request_threaded_irq@p(irq, NULL, ...) > > -- > 2.1.4 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules 2016-11-12 18:06 ` Julia Lawall @ 2016-11-18 11:22 ` Vaishali Thakkar 0 siblings, 0 replies; 8+ messages in thread From: Vaishali Thakkar @ 2016-11-18 11:22 UTC (permalink / raw) To: Julia Lawall Cc: mmarek, Gilles Muller, nicolas.palix, cocci, linux-kernel, lars On Saturday 12 November 2016 11:36 PM, Julia Lawall wrote: > > > On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > >> Currently because of the left associativity of the operators, pattern >> IRQF_ONESHOT | flags does not match with the pattern when we have more >> than one flag after the disjunction. This eventually results in giving >> false positives by the script. This patch eliminates these FPs by >> improving the rule. >> >> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> >> --- >> Changes since v2: >> - No change in this patch >> Changes since v1: >> - Splitted patch in the patchset >> --- >> scripts/coccinelle/misc/irqf_oneshot.cocci | 30 ++++++++++++++++++++++++------ >> 1 file changed, 24 insertions(+), 6 deletions(-) >> >> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci >> index b421150..a8537fb 100644 >> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci >> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci >> @@ -18,13 +18,12 @@ virtual report >> expression dev; >> expression irq; >> expression thread_fn; >> -expression flags; >> position p; >> @@ >> ( >> request_threaded_irq@p(irq, NULL, thread_fn, >> ( >> -flags | IRQF_ONESHOT >> +IRQF_ONESHOT | ... >> | >> IRQF_ONESHOT >> ) >> @@ -32,20 +31,39 @@ IRQF_ONESHOT >> | >> devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, >> ( >> -flags | IRQF_ONESHOT >> +IRQF_ONESHOT | ... >> | >> IRQF_ONESHOT >> ) >> , ...) >> ) >> >> -@depends on patch@ >> +@r2@ >> expression dev; >> expression irq; >> expression thread_fn; >> expression flags; >> +expression ret; >> position p != r1.p; >> @@ >> +flags = IRQF_ONESHOT | ...; >> +( >> +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); >> +| >> +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); >> +| >> +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); >> +| >> +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); >> +) > > This rule needs some improvement. > > flags = IRQF_ONESHOT | ...; > > should be replaced by: > > ( > flags = IRQF_ONESHOT | ... > | > flags |= IRQF_ONESHOT | ... > ) > ... when != flags = e > > where e should be a new expression metavariable. This effects a number of > changes. 1) Dropping the ; after the assignment allows an isomorphism to > trigger that allows it to match a variable declaration as well, 2) > IRQF_ONESHOT can be added after the original initialization by a |=, 3) > there can be some instructions between the initialization of flags and the > use. Ok, this makes sense. > Afterwards, the big disjunction with the irq calls is too specific. > In particular, these calls can also occur in an if test. The disjunction > should be replaced by the following: > > ( > request_threaded_irq@p(irq, NULL, thread_fn, flags, ...) > | > devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...) > ) Ok, primary motivation with having specified pattern was to have less running time. But as discussed, it doesn't make much difference. So, going with the more general way sounds good. Thanks for the suggestions. I'll send the the revised version with these changes. > julia > > >> + >> +@depends on patch@ >> +expression dev; >> +expression irq; >> +expression thread_fn; >> +expression flags; >> +position p != {r1.p,r2.p}; >> +@@ >> ( >> request_threaded_irq@p(irq, NULL, thread_fn, >> ( >> @@ -69,13 +87,13 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, >> ) >> >> @depends on context@ >> -position p != r1.p; >> +position p != {r1.p,r2.p}; >> @@ >> *request_threaded_irq@p(...) >> >> @match depends on report || org@ >> expression irq; >> -position p != r1.p; >> +position p != {r1.p,r2.p}; >> @@ >> request_threaded_irq@p(irq, NULL, ...) >> >> -- >> 2.1.4 >> >> -- Vaishali ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode 2016-10-24 12:24 [PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results Vaishali Thakkar 2016-10-24 12:19 ` [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules Vaishali Thakkar @ 2016-10-24 12:23 ` Vaishali Thakkar 2016-11-12 18:01 ` Julia Lawall 2016-10-24 12:24 ` [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes Vaishali Thakkar 2 siblings, 1 reply; 8+ messages in thread From: Vaishali Thakkar @ 2016-10-24 12:23 UTC (permalink / raw) To: mmarek Cc: julia.lawall, gilles.muller, nicolas.palix, cocci, linux-kernel, lars, Vaishali Thakkar To eliminate false positives given by the context mode, add necessary arguments for the function request_threaded_irq. Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> --- Changes since v2: - Add missing declaration of metavariable irq Changes since v1: - Split patch in to the patch set --- scripts/coccinelle/misc/irqf_oneshot.cocci | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci index a8537fb..e53372e 100644 --- a/scripts/coccinelle/misc/irqf_oneshot.cocci +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci @@ -87,9 +87,10 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ) @depends on context@ +expression irq; position p != {r1.p,r2.p}; @@ -*request_threaded_irq@p(...) +*request_threaded_irq@p(irq, NULL, ...) @match depends on report || org@ expression irq; -- 2.1.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode 2016-10-24 12:23 ` [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode Vaishali Thakkar @ 2016-11-12 18:01 ` Julia Lawall 0 siblings, 0 replies; 8+ messages in thread From: Julia Lawall @ 2016-11-12 18:01 UTC (permalink / raw) To: Vaishali Thakkar Cc: mmarek, julia.lawall, gilles.muller, nicolas.palix, cocci, linux-kernel, lars On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > To eliminate false positives given by the context mode, add > necessary arguments for the function request_threaded_irq. > > Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > Changes since v2: > - Add missing declaration of metavariable irq > Changes since v1: > - Split patch in to the patch set > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci > index a8537fb..e53372e 100644 > --- a/scripts/coccinelle/misc/irqf_oneshot.cocci > +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci > @@ -87,9 +87,10 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > ) > > @depends on context@ > +expression irq; > position p != {r1.p,r2.p}; > @@ > -*request_threaded_irq@p(...) > +*request_threaded_irq@p(irq, NULL, ...) > > @match depends on report || org@ > expression irq; > -- > 2.1.4 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes 2016-10-24 12:24 [PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results Vaishali Thakkar 2016-10-24 12:19 ` [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules Vaishali Thakkar 2016-10-24 12:23 ` [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode Vaishali Thakkar @ 2016-10-24 12:24 ` Vaishali Thakkar 2016-11-12 17:59 ` Julia Lawall 2 siblings, 1 reply; 8+ messages in thread From: Vaishali Thakkar @ 2016-10-24 12:24 UTC (permalink / raw) To: mmarek Cc: julia.lawall, gilles.muller, nicolas.palix, cocci, linux-kernel, lars, Vaishali Thakkar Add missing support for the devm_request_threaded_irq in the rules of context, report and org modes. Misc: ---- To be consistent with other scripts, change confidence level of the script to 'Moderate'. Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> --- Changes since v2: - Add missing initialization of metavariables Changes since v1: - Split patch in to the patchset --- scripts/coccinelle/misc/irqf_oneshot.cocci | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci index e53372e..ca78125 100644 --- a/scripts/coccinelle/misc/irqf_oneshot.cocci +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci @@ -5,7 +5,7 @@ /// So pass the IRQF_ONESHOT flag in this case. /// // -// Confidence: Good +// Confidence: Moderate // Comments: // Options: --no-includes @@ -87,16 +87,26 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ) @depends on context@ +expression dev; expression irq; position p != {r1.p,r2.p}; @@ +( *request_threaded_irq@p(irq, NULL, ...) +| +*devm_request_threaded_irq@p(dev, irq, NULL, ...) +) @match depends on report || org@ +expression dev; expression irq; position p != {r1.p,r2.p}; @@ +( request_threaded_irq@p(irq, NULL, ...) +| +devm_request_threaded_irq@p(dev, irq, NULL, ...) +) @script:python depends on org@ p << match.p; -- 2.1.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes 2016-10-24 12:24 ` [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes Vaishali Thakkar @ 2016-11-12 17:59 ` Julia Lawall 0 siblings, 0 replies; 8+ messages in thread From: Julia Lawall @ 2016-11-12 17:59 UTC (permalink / raw) To: Vaishali Thakkar Cc: mmarek, julia.lawall, gilles.muller, nicolas.palix, cocci, linux-kernel, lars On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > Add missing support for the devm_request_threaded_irq in > the rules of context, report and org modes. > > Misc: > ---- > To be consistent with other scripts, change confidence level > of the script to 'Moderate'. > > Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > Changes since v2: > - Add missing initialization of metavariables > Changes since v1: > - Split patch in to the patchset > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci > index e53372e..ca78125 100644 > --- a/scripts/coccinelle/misc/irqf_oneshot.cocci > +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci > @@ -5,7 +5,7 @@ > /// So pass the IRQF_ONESHOT flag in this case. > /// > // > -// Confidence: Good > +// Confidence: Moderate > // Comments: > // Options: --no-includes > > @@ -87,16 +87,26 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > ) > > @depends on context@ > +expression dev; > expression irq; > position p != {r1.p,r2.p}; > @@ > +( > *request_threaded_irq@p(irq, NULL, ...) > +| > +*devm_request_threaded_irq@p(dev, irq, NULL, ...) > +) > > @match depends on report || org@ > +expression dev; > expression irq; > position p != {r1.p,r2.p}; > @@ > +( > request_threaded_irq@p(irq, NULL, ...) > +| > +devm_request_threaded_irq@p(dev, irq, NULL, ...) > +) > > @script:python depends on org@ > p << match.p; > -- > 2.1.4 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-11-18 11:23 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-24 12:24 [PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results Vaishali Thakkar 2016-10-24 12:19 ` [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules Vaishali Thakkar 2016-11-12 18:06 ` Julia Lawall 2016-11-18 11:22 ` Vaishali Thakkar 2016-10-24 12:23 ` [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode Vaishali Thakkar 2016-11-12 18:01 ` Julia Lawall 2016-10-24 12:24 ` [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes Vaishali Thakkar 2016-11-12 17:59 ` Julia Lawall
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).