From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754507AbcAMWC5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jan 2016 17:02:57 -0500
Received: from mout.kundenserver.de ([217.72.192.75]:56482 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751159AbcAMWCz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jan 2016 17:02:55 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Wan ZongShun <mcuos.com@gmail.com>, David Woodhouse <dwmw2@infradead.org>,
        linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nuc900_nand: read correct SMISR register
Date: Wed, 13 Jan 2016 23:02:06 +0100
Message-ID: <5830403.0pR8UVXPRZ@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20160113215013.GS109450@google.com>
References: <9019174.GYajdpGP8V@wuerfel> <20160113215013.GS109450@google.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:0Zsr5vxlvbtRBMqI++969M6gRdWZy3D/oA+NxndWcToSCHPHNYC
 9xV8hDRwSuzCtKN5n8rvxbK2abtkFOR84Kj/8Rli9zfnWOtPxQrtMVaAobhsZyeQJs/C/Z0
 /hTd+zryUQqeWzwqocJSU1VmdNEiucJzFqq/s2LIJ17McU1biX2WoEqHzBon/f1hrtQ3zqM
 FGsdhdFJcp2tt9xb0Q5Aw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:5zydC1w1B+Q=:lAYswiDXC5RulMh3RIX5In
 2CAFvjSge3x2WpXyumgOumU3+8JZ6Xpr9bKQ4vpsCtbkh95S/E9FXngIfelscPOfM0jZzeEpP
 hEY7vH+sWjsGtq8k5huSbF72cmPAOu30ZyjBrtRMn2MZQFjxcYkl8TExwf8GnsJcGQ0D03Hea
 BsbfuQ17l1fJwhmNea422kVH+tsd2dX/RQ/YmfitQ7bytYyacG9dGa/kKsXDJILUHukt6Etsp
 XKgtj4fLHM081GiM2J3JE2xJW2Uk+Ywegm7ignfAfEkJG7SpmcdrGKoDk8vlPKNLb3ejHogU+
 BC/eYyG8OP8zAWuSyibT1NmpqG6V9Ah99fR22tU9hiQFPXK0jbDayM60MNd0clJYpD4IfaLmO
 nIiEZTA58y/p8V53hy2mhZeRhyvq/lh6rY8eTmzfbB/k0e3M1jZ0fhiTzRfDstNSeZWSGWBrp
 ecrDl9JvEmlvpITd+p/8Cpz54rtqXwo/0HxsBV+UonGlMBo3E7hzKHKHCNKvl9R7wNq97FB75
 a+bUeUWdAGPo/Eng+9iUHt2S/5WKEZ00DgbxDzXR2GO3k+q20egZyEFQJB7uyqYmDZQD5DG6L
 oic8kynCD6eYoi4ZxDdT+t4TqYOXBjYefvFSOAMJas5zRTrDPo/5prh2uasV9tD7EKATPjZ+w
 vjRtGl+EYHv1Bwlma5gTsXZP19pdj14vuHeWHqBo5tCOOm/NB1rUsziAf31G5ei8QWuA6pVMu
 6vHzIvJEXh+dirbA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 13 January 2016 13:50:13 Brian Norris wrote:
> 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > diff --git a/drivers/mtd/nand/nuc900_nand.c b/drivers/mtd/nand/nuc900_nand.c
> > index 220ddfcf29f5..dbc5b571c2bb 100644
> > --- a/drivers/mtd/nand/nuc900_nand.c
> > +++ b/drivers/mtd/nand/nuc900_nand.c
> > @@ -113,7 +113,7 @@ static int nuc900_check_rb(struct nuc900_nand *nand)
> >  {
> >       unsigned int val;
> >       spin_lock(&nand->lock);
> > -     val = __raw_readl(REG_SMISR);
> > +     val = __raw_readl(nand->reg + REG_SMISR);
> >       val &= READYBUSY;
> >       spin_unlock(&nand->lock);
> >  
> 
> Looks OK to me, though I kinda hate dragging on support for
> obviously-unused drivers...

Should we mark that driver in Kconfig as obviously broken then?

Let's wait for Wan ZongShun to reply first, it's possible that the
entire w90x900 platform has come to the point where we are better off
removing it than fixing ancient bugs.

	Arnd