From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754151AbcKXGuk (ORCPT ); Thu, 24 Nov 2016 01:50:40 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39710 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751075AbcKXGuj (ORCPT ); Thu, 24 Nov 2016 01:50:39 -0500 Subject: Re: [PATCH 1/5] mm: migrate: Add mode parameter to support additional page copy routines. To: Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20161122162530.2370-1-zi.yan@sent.com> <20161122162530.2370-2-zi.yan@sent.com> Cc: akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com, Zi Yan , Zi Yan From: Anshuman Khandual Date: Thu, 24 Nov 2016 12:20:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20161122162530.2370-2-zi.yan@sent.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112406-0012-0000-0000-000001EF5C2F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112406-0013-0000-0000-000006825BAF Message-Id: <58368DB4.40809@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-24_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611240118 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/2016 09:55 PM, Zi Yan wrote: > From: Zi Yan > > From: Zi Yan There are multiple "from" for this patch, should be fixed to reflect just one of them. > > migrate_page_copy() and copy_huge_page() are affected. In this patch you are just expanding the arguments of both of these functions to include "migration mode" which will then be implemented later by subsequent patches or should these patches me merged ? I guess its okay. Please reword the commit message to include details. > > Signed-off-by: Zi Yan > Signed-off-by: Zi Yan Just a singled Signed-off-by.