From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbcKXXhx (ORCPT ); Thu, 24 Nov 2016 18:37:53 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:42765 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbcKXXhm (ORCPT ); Thu, 24 Nov 2016 18:37:42 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61b-f796f6d000004092-57-583779c471f9 Content-transfer-encoding: 8BIT Message-id: <583779C4.9070707@samsung.com> Date: Fri, 25 Nov 2016 08:37:40 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Joe Perches , myungjoo.ham@samsung.com, kyungmin.park@samsung.com Cc: rjw@rjwysocki.net, chanwoo@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] PM / devfreq: Fix the checkpatch warnings References: <1479963668-22845-1-git-send-email-cw00.choi@samsung.com> <1479963668-22845-2-git-send-email-cw00.choi@samsung.com> <1479982838.19726.3.camel@perches.com> <5836C4F9.2010509@samsung.com> <1479984758.19726.7.camel@perches.com> In-reply-to: <1479984758.19726.7.camel@perches.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t9jQd0jleYRBidXiVtMvHGFxWL2/ccs Fmeb3rBbXN41h83ic+8RRovbjSvYLM6cvsTqwO6xaVUnm8eXVdeYPbZcbWfx6NuyitHj8ya5 ANYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgH uAcr6dsluGUsffKQtWAdV8WzNp4Gxu0cXYycHBICJhLLDm1mh7DFJC7cW8/WxcjFISQwi1Hi 5c7tYAleAUGJH5PvsXQxcnAwC8hLHLmUDWGqS0yZkgtR/oBR4t23zcwQ5VoSu+Y0MYLYLAKq Eps2LWUBsdmA4vtf3GADsfkFFCWu/njMCDJHVCBCovtEJUhYBMj8v2MlK4jNLJAsMf/CTrBW YQEnib7HvYwQu44xSXTcv80G0sspYCzx4YD/BEbBWUgOnYVw6CyEQxcwMq9ilEgtSC4oTkrP NcpLLdcrTswtLs1L10vOz93ECI64Z9I7GA/vcj/EKMDBqMTDa5FqHiHEmlhWXJl7iFGCg1lJ hPdEBVCINyWxsiq1KD++qDQntfgQoynQpxOZpUST84HJIK8k3tDE3MTc2MDC3NLSxEhJnLdx 9rNwIYH0xJLU7NTUgtQimD4mDk6pBsb2yq/GYVVZUQyWhrcU8t7q7gy6MDe0YsaEux8mSFl5 87Um3FKJl/bxmjNnHUPsI+O/un9TVy6ef+X+76Z57gKuczvDHz59c+Svqop3Y+qHx6Vp1ift ow7X3Wt+bSUcc2fnNIffC/PFmbKLdCe8il5g2b/n4jJRhd3MvoF5/IXixTu3a21do6DEUpyR aKjFXFScCACRJer3zgIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 11월 24일 19:52, Joe Perches wrote: > On Thu, 2016-11-24 at 19:46 +0900, Chanwoo Choi wrote: >> On 2016년 11월 24일 19:20, Joe Perches wrote: >>> On Thu, 2016-11-24 at 14:01 +0900, Chanwoo Choi wrote: >>>> This patch just fixes the checkpatch warnings. >>> >>> unrelated trivia: >>> >>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > [] >>>> @@ -576,11 +575,13 @@ struct devfreq *devfreq_add_device(struct device *dev, >>>> goto err_out; >>>> } >>>> >>>> - devfreq->trans_table = devm_kzalloc(&devfreq->dev, sizeof(unsigned int) * >>>> + devfreq->trans_table = devm_kzalloc(&devfreq->dev, >>>> + sizeof(unsigned int) * >>>> devfreq->profile->max_state * >>>> devfreq->profile->max_state, >>>> GFP_KERNEL); >>>> - devfreq->time_in_state = devm_kzalloc(&devfreq->dev, sizeof(unsigned long) * >>>> + devfreq->time_in_state = devm_kzalloc(&devfreq->dev, >>>> + sizeof(unsigned long) * >>>> devfreq->profile->max_state, >>>> GFP_KERNEL); >>> >>> Maybe these should be devm_kcalloc calls >> >> Why should devfreq use the devm_kcalloc? > > Because these are allocating zeroed arrays of a specific size. kzalloc is already set to zero. [1]https://www.kernel.org/doc/htmldocs/kernel-api/API-kzalloc.html