From: wangyijing <wangyijing@huawei.com>
To: Coly Li <i@coly.li>, <axboe@fb.com>, <kent.overstreet@gmail.com>
Cc: <git@linux.ewheeler.net>, <colyli@suse.de>,
<linux-bcache@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] bcache: remove unused parameter
Date: Mon, 28 Nov 2016 08:51:59 +0800 [thread overview]
Message-ID: <583B7FAF.30601@huawei.com> (raw)
In-Reply-To: <b5051477-73bd-0c74-a371-2c2f547e5c6e@coly.li>
在 2016/11/27 16:00, Coly Li 写道:
> On 2016/11/25 上午9:40, Yijing Wang wrote:
>> Parameter bio is no longer used, clean it.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>> drivers/md/bcache/request.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
>> index 40ffe5e..bf6e432 100644
>> --- a/drivers/md/bcache/request.c
>> +++ b/drivers/md/bcache/request.c
>> @@ -26,12 +26,12 @@ struct kmem_cache *bch_search_cache;
>>
>> static void bch_data_insert_start(struct closure *);
>>
>> -static unsigned cache_mode(struct cached_dev *dc, struct bio *bio)
>> +static unsigned cache_mode(struct cached_dev *dc)
>> {
>> return BDEV_CACHE_MODE(&dc->sb);
>> }
>>
>> -static bool verify(struct cached_dev *dc, struct bio *bio)
>> +static bool verify(struct cached_dev *dc)
>> {
>> return dc->verify;
>> }
>> @@ -371,7 +371,7 @@ static struct hlist_head *iohash(struct cached_dev *dc, uint64_t k)
>> static bool check_should_bypass(struct cached_dev *dc, struct bio *bio)
>> {
>> struct cache_set *c = dc->disk.c;
>> - unsigned mode = cache_mode(dc, bio);
>> + unsigned mode = cache_mode(dc);
>> unsigned sectors, congested = bch_get_congested(c);
>> struct task_struct *task = current;
>> struct io *i;
>> @@ -746,7 +746,7 @@ static void cached_dev_read_done(struct closure *cl)
>> s->cache_miss = NULL;
>> }
>>
>> - if (verify(dc, &s->bio.bio) && s->recoverable && !s->read_dirty_data)
>> + if (verify(dc) && s->recoverable && !s->read_dirty_data)
>> bch_data_verify(dc, s->orig_bio);
>>
>> bio_complete(s);
>> @@ -771,7 +771,7 @@ static void cached_dev_read_done_bh(struct closure *cl)
>>
>> if (s->iop.error)
>> continue_at_nobarrier(cl, cached_dev_read_error, bcache_wq);
>> - else if (s->iop.bio || verify(dc, &s->bio.bio))
>> + else if (s->iop.bio || verify(dc))
>> continue_at_nobarrier(cl, cached_dev_read_done, bcache_wq);
>> else
>> continue_at_nobarrier(cl, cached_dev_bio_complete, NULL);
>> @@ -898,7 +898,7 @@ static void cached_dev_write(struct cached_dev *dc, struct search *s)
>> s->iop.bypass = true;
>>
>> if (should_writeback(dc, s->orig_bio,
>> - cache_mode(dc, bio),
>> + cache_mode(dc),
>> s->iop.bypass)) {
>> s->iop.bypass = false;
>> s->iop.writeback = true;
>>
>
> Acked-by: Coly Li <colyli@suse.de>
Thanks!
>
prev parent reply other threads:[~2016-11-28 0:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 1:40 [PATCH 2/2] bcache: remove unused parameter Yijing Wang
2016-11-27 8:00 ` Coly Li
2016-11-28 0:51 ` wangyijing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583B7FAF.30601@huawei.com \
--to=wangyijing@huawei.com \
--cc=axboe@fb.com \
--cc=colyli@suse.de \
--cc=git@linux.ewheeler.net \
--cc=i@coly.li \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).