From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Baolin Wang <baolin.wang@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>
Cc: mathias.nyman@intel.com, USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement
Date: Mon, 28 Nov 2016 17:14:50 +0200 [thread overview]
Message-ID: <583C49EA.5060504@linux.intel.com> (raw)
In-Reply-To: <CAMz4kuJ7fqvD+WWYWc4M1PQxYP2xGA9Jkc6Gxz0FdfNzaxN19g@mail.gmail.com>
On 28.11.2016 09:41, Baolin Wang wrote:
> On 28 November 2016 at 15:21, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote:
>>> Hi Mathias,
>>>
>>> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org> wrote:
>>>> Since these 'return' statements are not generally useful in void
>>>> function, remove them. Also remove one unuseful 'break' statement
>>>> in xhci_setup_addressable_virt_dev() function.
>>>>
>>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>>> ---
>>>> Changes since v1:
>>>> - Add description of removing 'break' statement in commitlog.
>>>> ---
>>>
>>> Could you apply this patch if there are no other comments? Thanks.
>>
>> Less than a week response for a simple cleanup patch? Why the rush and
>> pressure? Relax, this really isn't an important patch...
>
> I am sorry for the pressure, I just thought it is one simple cleanup
> patch. It is okay for me to wait for.
>
Looks ok.
If it applies I'll send it forward to usb-next after 4.10-rc1,
It should end up in 4.11
-Mathias
next prev parent reply other threads:[~2016-11-28 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 11:16 [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang
2016-11-28 6:29 ` Baolin Wang
2016-11-28 7:21 ` Greg KH
2016-11-28 7:41 ` Baolin Wang
2016-11-28 15:14 ` Mathias Nyman [this message]
2016-11-29 2:27 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583C49EA.5060504@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox