From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbcLGFyi (ORCPT ); Wed, 7 Dec 2016 00:54:38 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:37986 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbcLGFyg (ORCPT ); Wed, 7 Dec 2016 00:54:36 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61a-f79916d0000062de-98-5847a4195903 Content-transfer-encoding: 8BIT Message-id: <5847A419.9050801@samsung.com> Date: Wed, 07 Dec 2016 14:54:33 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski Cc: javier@osg.samsung.com, kgene@kernel.org, robh+dt@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: dts: exynos5433: Add PPMU dt node References: <1480663087-4590-1-git-send-email-cw00.choi@samsung.com> <1480663087-4590-4-git-send-email-cw00.choi@samsung.com> <20161206190756.GA12683@kozik-lap> <58478C41.5090500@samsung.com> In-reply-to: <58478C41.5090500@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsVy+t9jAV3JJe4RBg8+GFrMP3KO1eLN2zVM Fv2PXzNbnD+/gd3ibNMbdotNj6+xWlzeNYfNYsb5fUwWtxtXsFm07j3CbnH4TTurxapdfxgd eDx2zrrL7rFpVSebx+Yl9R5b+oG8vi2rGD0+b5ILYItys8lITUxJLVJIzUvOT8nMS7dVCg1x 07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8azlS9YC/aJVUxon8PSwHhS qIuRk0NCwERi7oVGFghbTOLCvfVsXYxcHEICSxklHnYdZQdJ8AoISvyYfA+oiIODWUBe4sil bAhTXWLKlFyQCiGBB4wS/6/YQVRrSSz8/ocRxGYRUJWY9PEwK4jNBhTf/+IGG4jNL6AocfXH Y0aQMaICERLdJypBwiICmhLX/35nBbmAWWA9k8SUzglg9cICjhLN5z6xQpw2nUni38QuZpAE p4C2xPODN9knMArOQnLpLIRLZyFcuoCReRWjRGpBckFxUnquYV5quV5xYm5xaV66XnJ+7iZG cLw+k9rBeHCX+yFGAQ5GJR7egktuEUKsiWXFlbmHGCU4mJVEeD8udI8Q4k1JrKxKLcqPLyrN SS0+xGgK9OtEZinR5HxgKskriTc0MTcxNzawMLe0NDFSEudtnP0sXEggPbEkNTs1tSC1CKaP iYNTqoGRa/dhZeZJCyPmzrrn7uxZ+6m3ferJ92GFVzreaLqfeGD7x2NfnklreO+jOckvj1bo 3eDleLpnVWzA0Xcp4S3sxScfxToG6azL3zF9hkeA4pafLW2r+CzV6s8/Ty86xDFp37I9dwrV L835KypkdsuII+/qthxFv2cnp1U/On9j+WEe/n7vZbvfKrEUZyQaajEXFScCAEBtUYrtAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 12월 07일 13:12, Chanwoo Choi wrote: > On 2016년 12월 07일 04:07, Krzysztof Kozlowski wrote: >> On Fri, Dec 02, 2016 at 04:18:05PM +0900, Chanwoo Choi wrote: >>> This patch adds PPMU (Platform Performance Monitoring Unit) Device-tree node >>> to measure the utilization of each IP in Exynos SoC. >>> >>> - PPMU_D{0|1}_CPU are used to measure the utilization of MIF (Memory Interface) >>> block with VDD_MIF power source. >>> - PPMU_D{0|1}_GENERAL are used to measure the utilization of INT(Internal) >>> block with VDD_INT power source. >>> >>> Signed-off-by: Chanwoo Choi >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>> index 64226d5ae471..8c4ee84d5232 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>> @@ -599,6 +599,30 @@ >>> clock-names = "fin_pll", "mct"; >>> }; >>> >>> + ppmu_d0_cpu: ppmu@10480000 { >>> + compatible = "samsung,exynos-ppmu-v2"; >>> + reg = <0x10480000 0x2000>; >>> + status = "disabled"; >> >> Why these are disabled? They have some external dependencies? > > There is no any dependency. If you want to remain it always enabled, > I'm OK. One more comment. Each PPMU has the four events which is used for devfreq driver to get the utilization. If I remove the 'status = "disabled"' from exynos5433.dtsi, first probe of PPMU device is fail on case1. Case1. Disable PPMU device and then enable it on exynos5433-tm2.dts [ 2.560126] exynos-ppmu: new PPMU device registered 10490000.ppmu (ppmu-event0-d0-general) [ 2.565957] exynos-ppmu: new PPMU device registered 104c0000.ppmu (ppmu-event0-d1-general) Case2. Enable PPMU device always. First probe is failed and then second probe is successful. [ 2.898781] exynos-ppmu 10480000.ppmu: failed to get child node of devfreq-event devices [ 2.899077] exynos-ppmu 10480000.ppmu: failed to parse exynos ppmu dt node [ 2.899289] exynos-ppmu 10480000.ppmu: failed to parse devicetree for resource [ 2.899602] exynos-ppmu: probe of 10480000.ppmu failed with error -22 [ 2.905364] exynos-ppmu: new PPMU device registered 10490000.ppmu (ppmu-event0-d0-general) [ 2.913535] exynos-ppmu 104b0000.ppmu: failed to get child node of devfreq-event devices [ 2.921402] exynos-ppmu 104b0000.ppmu: failed to parse exynos ppmu dt node [ 2.928250] exynos-ppmu 104b0000.ppmu: failed to parse devicetree for resource [ 2.935571] exynos-ppmu: probe of 104b0000.ppmu failed with error -22 [ 2.942144] exynos-ppmu: new PPMU device registered 104c0000.ppmu (ppmu-event0-d1-general) Best Regards, Chanwoo Choi [snip]