From: Thorsten Blum <thorsten.blum@linux.dev>
To: Waiman Long <llong@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: x86/smpboot: Question regarding native_play_dead() __noreturn warning
Date: Mon, 27 Oct 2025 17:23:02 +0100 [thread overview]
Message-ID: <58486755-0AA7-47DC-B914-1DF92483F69E@linux.dev> (raw)
In-Reply-To: <4be37a6a-0a04-48f8-9399-25ecb4638cdc@redhat.com>
On 27. Oct 2025, at 16:48, Waiman Long wrote:
> On 10/27/25 8:50 AM, Peter Zijlstra wrote:
>> On Mon, Oct 27, 2025 at 01:23:02PM +0100, Thorsten Blum wrote:
>>> [...]
>> I'm not sure either, it wasn't there in v2 but appeared in v3.
>>
>> v2: 20230620140625.1001886-3-longman@redhat.com
>> v3: 20230622003603.1188364-2-longman@redhat.com
>>
>> The difference is that v2 tried to restore the msr after 'play_dead'
>> which is silly, since it would never reach that code. v3 removed that
>> dead restore code and added the confusing comment.
>>
>> There is a clue here though:
>>
>> 20230622054053.uy577qezu5a65buc@treble
>>
>> Josh suggests play_dead() should be marked noreturn (which it is in
>> current kernels).
>>
>> Waiman then replies:
>>
>> 921e1b98-af36-1f51-5abe-dea36425b706@redhat.com
>>
>> which is utterly confused again.
>
> I don't remember exactly how I got the warning when __noreturn is added to native_play_dead(). It may be a limitation of the objtool or gcc that I was using at that time. If Thorsten doesn't have problem adding __noreturn, I won't mind him doing that and taking out the the comment. We can see if there is other issue coming up in the future.
Thanks for the quick replies!
I submitted the patch adding __noreturn here:
https://lore.kernel.org/lkml/20251027155107.183136-1-thorsten.blum@linux.dev/
prev parent reply other threads:[~2025-10-27 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 12:23 x86/smpboot: Question regarding native_play_dead() __noreturn warning Thorsten Blum
2025-10-27 12:50 ` Peter Zijlstra
2025-10-27 15:48 ` Waiman Long
2025-10-27 16:23 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58486755-0AA7-47DC-B914-1DF92483F69E@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llong@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox