Re: [PATCH 06/12] riscv: dts: allwinner: Add the D1 SoC base devicetree

Krzysztof Kozlowski
2022-08-17T08:29:25Z

On 15/08/2022 08:08, Samuel Holland wrote:
> D1 is a SoC containing a single-core T-HEAD Xuantie C906 CPU, as well as
> one HiFi 4 DSP. The SoC is based on a design that additionally contained
> a pair of Cortex A7's. For that reason, some peripherals are duplicated.
>
> This devicetree includes all of the peripherals that already have a
> documented binding.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>

(...)

> +
> + codec: audio-codec@2030000 {
> + compatible = "simple-mfd", "syscon";

This alone is not correct. You must use device specific compatible.

> + reg = <0x2030000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + regulators@2030348 {
> + compatible = "allwinner,sun20i-d1-analog-ldos";
> + reg = <0x2030348 0x4>;
> + nvmem-cells = <&bg_trim>;
> + nvmem-cell-names = "bg_trim";
> +
> + reg_aldo: aldo {
> + };
> +
> + reg_hpldo: hpldo {
> + };
> + };
> + };

Best regards,
Krzysztof