From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932794AbcLHWNK (ORCPT ); Thu, 8 Dec 2016 17:13:10 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35225 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932674AbcLHWNJ (ORCPT ); Thu, 8 Dec 2016 17:13:09 -0500 Message-ID: <5849DAEE.9050408@gmail.com> Date: Thu, 08 Dec 2016 22:13:02 +0000 From: Sudip Mukherjee User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Greg Kroah-Hartman , Colin King CC: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ppdev: don't print a free'd string References: <20161202162355.25470-1-colin.king@canonical.com> <20161206105138.GA10275@kroah.com> In-Reply-To: <20161206105138.GA10275@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 06 December 2016 10:51 AM, Greg Kroah-Hartman wrote: > On Fri, Dec 02, 2016 at 04:23:55PM +0000, Colin King wrote: >> From: Colin Ian King >> >> A previous fix of a memory leak now prints the string 'name' >> that was previously free'd. Fix this by free'ing the string >> at the end of the function and adding an error exit path for >> the error conditions. >> >> CoverityScan CID#1384523 ("Use after free") >> >> Fixes: 2bd362d5f45c1 ("ppdev: fix memory leak") >> Signed-off-by: Colin Ian King >> --- >> drivers/char/ppdev.c | 13 ++++++++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) > > Sudip, any thoughts? > Hi Greg, Sorry for the late reply. It looks good. Acked-by: Sudip Mukherjee Regards Sudip