From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbcLLNAa (ORCPT ); Mon, 12 Dec 2016 08:00:30 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:50048 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbcLLNA3 (ORCPT ); Mon, 12 Dec 2016 08:00:29 -0500 Message-ID: <584E9F6D.1080209@ti.com> Date: Mon, 12 Dec 2016 07:00:29 -0600 From: Dan Murphy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Dmitry Torokhov CC: , Subject: Re: [PATCH] Input: drv260x - fix initializing overdrive voltage References: <20161211065956.GA17809@dtor-ws> In-Reply-To: <20161211065956.GA17809@dtor-ws> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitry On 12/11/2016 12:59 AM, Dmitry Torokhov wrote: > We were accidentally initializing haptics->rated_voltage twice, and did not > initialize overdrive voltage. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/misc/drv260x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c > index 2adfd86c..9789d4f 100644 > --- a/drivers/input/misc/drv260x.c > +++ b/drivers/input/misc/drv260x.c > @@ -521,7 +521,7 @@ static int drv260x_probe(struct i2c_client *client, > if (!haptics) > return -ENOMEM; > > - haptics->rated_voltage = DRV260X_DEF_OD_CLAMP_VOLT; > + haptics->overdrive_voltage = DRV260X_DEF_OD_CLAMP_VOLT; > haptics->rated_voltage = DRV260X_DEF_RATED_VOLT; > > if (pdata) { Thanks for the fix Acked-by: Dan Murphy -- ------------------ Dan Murphy