From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbbJFUhU (ORCPT ); Tue, 6 Oct 2015 16:37:20 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:60245 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752804AbbJFUhS (ORCPT ); Tue, 6 Oct 2015 16:37:18 -0400 From: Arnd Bergmann To: Matthew Wilcox Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , linux-arm-kernel@lists.infradead.org Subject: [PATCH] nvme: fix 32-bit build warning Date: Tue, 06 Oct 2015 22:37:11 +0200 Message-ID: <5851501.PBMrs03XFb@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:KhHbh35Y0jxZH7q+2tq9FD2cmuanHRr7tRaQtkOffg8BXiQ4MqK jJh3bKFFyPZXWn/o+Fr3FGyow+s+4/vvxnMkpoJjVOz0UQyG5TmvQ6A69PtzZagvEAzhDU7 cc2AciJn4ESi11vOig5/O/GZmnqOKUv9XXX+698R+OD0VIZbNgx3uHJD1htr33zJOxSI++l FwhausHVPBJ0Mv40ov2+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:xBrMAckoXsM=:mj+GPhkgNDGA4KKLR+lo99 wZsrj3YgN/t3d+GWgsOwN36vxD5vUr8+TGbI5jx4r7jZqAhN62aHH3xojSCF0tnJf9paCiXL8 BSCLzI0dc8UPC8QehjuLxkK4R5lwllXXPH0T8+PjOam/OcQCYJuEhN0D4vzqpFbwHCutt9+jA rm87x2HHAaw2PypAm2vp9uMJDIwp6S6JttbbvIobwlLWY40Rie6c6g+HjoRI8o/a13oemUIG8 ZFzmcfHYq6whXSbD2VbAt618sEhQO09a3mlWH8tQHFN/OPscWe3YqkAwN+NXrKKapMZG7O5S1 EQqbyOMIkHQYNr+uXl0VsXFoz58BAkhjynM4z0npQJsOxmNB7zO9kvwnF33gWFUm3lgOGuNjq jVXM+qsCobIY2gErZCjgZldqMJsp+flnNH0B9UfFhLc7Y1y8NiD371ZD6Ju5ABldN+sBf10LN rWObXwXjOcvZFGaFzhSVVZ8UZ50e41cztXmW1IpaP2S+5MJXZmEGwFwxgUMa2h6XVUtaxMHTY 4yTcMkxHikYfnDNPwfdFnjeC2eoXHIkejzo+CVgVAdQZw5tuG9odIOZ2ySRKweSe+Q+cug9BT 3Kyeqgr1L9wkTAvaqWhr4+UjfjoEqvn+t3Waw4mnT3zc6aGbJl5PgqO8LErySDbph5mQpe3Us Ot696mhM5AsLeSPN7f3/qur7s1c+db/XGOJWb02TpQlnIUMBYsPlRSq5APRQdWuInIweunLlH axD1EZQ2EyGHgPoW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Compiling the nvme driver on 32-bit warns about a cast from a __u64 variable to a pointer: drivers/block/nvme-core.c: In function 'nvme_submit_io': drivers/block/nvme-core.c:1847:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (void __user *)io.addr, length, NULL, 0); The cast here is intentional and safe, so we can shut up the gcc warning by adding an intermediate cast to 'unsigned long'. I had previously submitted a patch to fix this problem in the nvme driver, but it was accepted on the same day that two new warnings got added. Signed-off-by: Arnd Bergmann Fixes: d29ec8241c10e ("nvme: submit internal commands through the block layer") diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index e917cf304ad0..f9faf276ce74 100644 --- a/drivers/block/nvme-core.c +++ b/drivers/block/nvme-core.c @@ -1844,7 +1844,7 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio) c.rw.metadata = cpu_to_le64(meta_dma); status = __nvme_submit_sync_cmd(ns->queue, &c, NULL, - (void __user *)io.addr, length, NULL, 0); + (void __user *)(unsigned long)io.addr, length, NULL, 0); unmap: if (meta) { if (status == NVME_SC_SUCCESS && !write) { @@ -1886,7 +1886,7 @@ static int nvme_user_cmd(struct nvme_dev *dev, struct nvme_ns *ns, timeout = msecs_to_jiffies(cmd.timeout_ms); status = __nvme_submit_sync_cmd(ns ? ns->queue : dev->admin_q, &c, - NULL, (void __user *)cmd.addr, cmd.data_len, + NULL, (void __user *)(unsigned long)cmd.addr, cmd.data_len, &cmd.result, timeout); if (status >= 0) { if (put_user(cmd.result, &ucmd->result))