From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752895AbcLSGKh (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Dec 2016 01:10:37 -0500
Received: from mailout4.samsung.com ([203.254.224.34]:33972 "EHLO
        mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750763AbcLSGKg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Dec 2016 01:10:36 -0500
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
X-AuditID: cbfee61a-f79bd6d000000fc6-0c-585779dabc00
Content-transfer-encoding: 8BIT
Message-id: <585779DA.20402@samsung.com>
Date: Mon, 19 Dec 2016 15:10:34 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.6.0
To: Hans de Goede <hdegoede@redhat.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] extcon: axp288: Simplify axp288_handle_chrg_det_event
References: <20161219001313.13402-1-hdegoede@redhat.com>
 <CGME20161219001320epcas1p1b0842ad573c4dcad93142c22bc7177e5@epcas1p1.samsung.com>
 <20161219001313.13402-3-hdegoede@redhat.com>
In-reply-to: <20161219001313.13402-3-hdegoede@redhat.com>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t9jAd1bleERBgc69SzeHJ/OZHF51xw2
        i9uNK9gcmD3e77vK5tG3ZRWjx+dNcgHMUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5
        qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLmH3+GXvBJ9aKRStXsjQwvmPpYuTkkBAw
        kehpv8AEYYtJXLi3ng3EFhJYyigxaUI9iM0rICjxY/I9oHoODmYBeYkjl7JBwswC6hKT5i1i
        hih/wCjR/KMQolxD4uHDB2wg5SwCqhKzPuqAhNkEtCT2v7gBNp1fQFHi6o/HjCAlogIREt0n
        KkHCIgIBEj9P9bNDTFeQ+HVvEytIibCAn0TroZguRi6gRbsZJa4suA42hlPAUuJGQw/LBEbB
        WUjunIVw5ywkdy5gZF7FKJFakFxQnJSea5iXWq5XnJhbXJqXrpecn7uJERw1z6R2MB7c5X6I
        UYCDUYmHt+B9WIQQa2JZcWXuIUYJDmYlEV6R8vAIId6UxMqq1KL8+KLSnNTiQ4ymQJ9OZJYS
        Tc4HRnReSbyhibmJubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2MswSviWw8
        dWrtecGCiuepkzeIz3HsSbL78P4GJ3d76pTLNVXyu3sLGz+v8PmQ6Lbz9Ftet06X7Yt0Lzm+
        ZZt360rUqmMtmsEV1eGh//p2blj1M+rR2neuWvfWCptPOuBS4MvFW/r9/cT5nNPi3jsl6bXX
        SNxLlrQVZ9tVkDx/6qy0hYZFYmpeSizFGYmGWsxFxYkAD+Gkc7ACAAA=
X-MTR: 20000000000000000@CPGS
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hans,

On 2016년 12월 19일 09:13, Hans de Goede wrote:
> axp288_handle_chrg_det_event only gets called on change interrupts
> (so not that often), extcon_set_state_sync() checks itself if there are
> any actual changes before notifying listeners, and gpiod_set_value is
> not really expensive either.
> 
> So we can simply always do both on each interrupt removing a bunch of
> somewhat magic looking code from axp288_handle_chrg_det_event.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/extcon/extcon-axp288.c | 37 ++++++++++++-------------------------
>  1 file changed, 12 insertions(+), 25 deletions(-)

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Regards,
Chanwoo Choi