From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752259AbcLSGbe (ORCPT ); Mon, 19 Dec 2016 01:31:34 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:34917 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbcLSGbd (ORCPT ); Mon, 19 Dec 2016 01:31:33 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61b-f79d86d00000197e-3d-58577ec235ed Content-transfer-encoding: 8BIT Message-id: <58577EC2.4020807@samsung.com> Date: Mon, 19 Dec 2016 15:31:30 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] extcon: axp288: Make a couple of messages dev_info instead of dev_dbg References: <20161219001313.13402-1-hdegoede@redhat.com> <20161219001313.13402-5-hdegoede@redhat.com> In-reply-to: <20161219001313.13402-5-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jAd3DdeERBrf2slm8OT6dyeLyrjls FrcbV7A5MHu833eVzaNvyypGj8+b5AKYo9xsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJz U22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWMe/eGtaCq/wVOw6eYGtgPMXTxcjJISFg IrHg2ARWCFtM4sK99WxdjFwcQgJLGSU+n3vCBJLgFRCU+DH5HksXIwcHs4C8xJFL2SBhZgF1 iUnzFjGD2EICDxglJkxUgCjXkji6ch87iM0ioCpx7PkdFhCbDSi+/8UNNhCbX0BR4uqPx4wg I0UFIiS6T1SChEUEAiR+nupnhxivIPHr3iZWkBJhgQSJvWeyIS7bzSixoeUx2BhOAUuJjvab TBMYBWchOXQWwqGzkBy6gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZw5DyT3sF4 eJf7IUYBDkYlHt4J3OERQqyJZcWVuYcYJTiYlUR4RcqBQrwpiZVVqUX58UWlOanFhxhNgV6d yCwlmpwPjOq8knhDE3MTc2MDC3NLSxMjJXHextnPwoUE0hNLUrNTUwtSi2D6mDg4pRoYnU4v Pb/lfpmpcqHd9bDC1c0nzJU2aDmkxu3bvjy8KdiWX+redRcTFa3s+NsqQsfdbAtuJbnuqmr4 KP9uXY764T3J6eXrt5YcNThu46RS8XXV2hAJq4lf9rLZ/P+s88Sm49qBP5Gr+1mCAmVmHNv5 xsZme4mjZpz8AxfHagndiaeD5O4dCJqixFKckWioxVxUnAgAhE6e8rICAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, I prefer to use the dev_dbg on the fly instead of dev_info. If you want to check the change state, you can use the udev monitor tool because extcon send the uevent when changing the state of connector. Regards, Chanwoo Choi On 2016년 12월 19일 09:13, Hans de Goede wrote: > These messages are helpful for the user to check if their charger is > correctly detected, so make them dev_dbg instead of dev_info. > > Also add a new message to indicate when the vbus is disconnected / > no cable is detected. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-axp288.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index ded0bd9..fc636f6 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -167,8 +167,10 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) > } > > vbus_attach = (pwr_stat & PS_STAT_VBUS_PRESENT); > - if (!vbus_attach) > + if (!vbus_attach) { > + dev_info(info->dev, "vbus/cable disconnected\n"); > goto no_vbus; > + } > > /* Check charger detection completion status */ > ret = regmap_read(info->regmap, AXP288_BC_GLOBAL_REG, &cfg); > @@ -187,15 +189,15 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) > > switch (chrg_type) { > case DET_STAT_SDP: > - dev_dbg(info->dev, "sdp cable is connected\n"); > + dev_info(info->dev, "sdp cable is connected\n"); > cable = EXTCON_CHG_USB_SDP; > break; > case DET_STAT_CDP: > - dev_dbg(info->dev, "cdp cable is connected\n"); > + dev_info(info->dev, "cdp cable is connected\n"); > cable = EXTCON_CHG_USB_CDP; > break; > case DET_STAT_DCP: > - dev_dbg(info->dev, "dcp cable is connected\n"); > + dev_info(info->dev, "dcp cable is connected\n"); > cable = EXTCON_CHG_USB_DCP; > break; > default: >