From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbcLSGvt (ORCPT ); Mon, 19 Dec 2016 01:51:49 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:52665 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbcLSGvq (ORCPT ); Mon, 19 Dec 2016 01:51:46 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61b-f79d86d00000197e-7b-585783803a67 Content-transfer-encoding: 8BIT Message-id: <58578380.7000901@samsung.com> Date: Mon, 19 Dec 2016 15:51:44 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] extcon: axp288: Fix the module not auto-loading References: <20161219001313.13402-1-hdegoede@redhat.com> <20161219001313.13402-8-hdegoede@redhat.com> In-reply-to: <20161219001313.13402-8-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t9jAd2G5vAIg41brCzeHJ/OZHF51xw2 i9uNK9gcmD3e77vK5tG3ZRWjx+dNcgHMUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5 qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLWLR6OWPBQo6KU82dzA2Mt9i6GDk5JARM JC68WcsMYYtJXLi3HijOxSEksJRRYvHydUwgCV4BQYkfk++xdDFycDALyEscuZQNEmYWUJeY NG8RM0T9A0aJv2c/skLUa0nMa1zDCFLPIqAqsXwXO0iYDSi8/8UNsL38AooSV388BisRFYiQ 6D5RCRIWEQiQ+Hmqnx1ivILEr3ubwCYKC3hInJo2lRFi1W5GibbvP8BO4xSwlJg7fRPTBEbB WUgunYVw6Swkly5gZF7FKJFakFxQnJSea5SXWq5XnJhbXJqXrpecn7uJERw7z6R3MB7e5X6I UYCDUYmHdwJ3eIQQa2JZcWXuIUYJDmYlEd7yBqAQb0piZVVqUX58UWlOavEhRlOgVycyS4km 5wPjOq8k3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTUgtQimD4mDk6pBsauqRzTjAtq dldJ7GUOyFnROPuxvk+ibe6ajdc3nt8dVh+VwBeqI78g8OCKWUe/TvTuXynTVJzkfG5apeQ8 2SzbUOk17w+caVx1KOj8E+Gw3K9WLIs5T2mEbVVdf4Tjc/AdxV26uw7P4mVcr5kx2/Oqcu2/ a/m32W/0bpDQM/AWESz90bz+1l8lluKMREMt5qLiRABfXdhVswIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On 2016년 12월 19일 09:13, Hans de Goede wrote: > Add a MODULE_DEVICE_TABLE to fix the module not auto-loading. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-axp288.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index a27ee68..509a5f9 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -320,8 +320,15 @@ static int axp288_extcon_probe(struct platform_device *pdev) > return 0; > } > > +static const struct platform_device_id axp288_extcon_table[] = { > + { .name = "axp288_extcon" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(platform, axp288_extcon_table); > + > static struct platform_driver axp288_extcon_driver = { > .probe = axp288_extcon_probe, > + .id_table = axp288_extcon_table, > .driver = { > .name = "axp288_extcon", > }, > Looks good to me. Acked-by: Chanwoo Choi -- Regards, Chanwoo Choi