From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754459AbcLSG6J (ORCPT ); Mon, 19 Dec 2016 01:58:09 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:45907 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbcLSG6H (ORCPT ); Mon, 19 Dec 2016 01:58:07 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61a-f79bd6d000000fc6-88-585784fdc927 Content-transfer-encoding: 8BIT Message-id: <585784FD.3060602@samsung.com> Date: Mon, 19 Dec 2016 15:58:05 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data References: <20161219001313.13402-1-hdegoede@redhat.com> <585779C1.9080402@samsung.com> In-reply-to: <585779C1.9080402@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t9jAd2/LeERBjOviVu8OT6dyeLyrjls FrcbV7A5MHu833eVzaNvyypGj8+b5AKYo9xsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJz U22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWsX3dJ7aCGzwVE27FNzDO4Opi5OSQEDCR mP6znwXCFpO4cG89WxcjF4eQwFJGieuHXjGDJHgFBCV+TL4HVMTBwSwgL3HkUjaEqS4xZUou RPkDRomeN8egyrUk3jScBpvJIqAqMfXsXzYQmw0ovv/FDTCbX0BR4uqPx4wgc0QFIiS6T1SC hEUEAiR+nupnB7GZBRQkft3bxApiCwtESfSv/s4IsWsto8SCO+cYQRKcAtoSf9ZNY53AKDgL yaWzEC6dhXDpAkbmVYwSqQXJBcVJ6bmGeanlesWJucWleel6yfm5mxjBcfNMagfjwV3uhxgF OBiVeHgL3odFCLEmlhVX5h5ilOBgVhLhLW8IjxDiTUmsrEotyo8vKs1JLT7EaAr06kRmKdHk fGBM55XEG5qYm5gbG1iYW1qaGCmJ8zbOfhYuJJCeWJKanZpakFoE08fEwSnVwNgrIzmbVStI 9qG+Lav+L64Lf72OyTakzQg/sTxjw8FpXdL1r5KUj+k4nEirkIoXXD31gvnFD9tWfdDYojJz sWbCmvCEpyp8p/NDf63d3iF675eM0J5dX3cyfC7c/3Ivn+s+5amvQ3O/SD/a72xxYEOPnl+j 0x/tsvs12TntCsL73upYnY7wdVFiKc5INNRiLipOBACw3/X/sQIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, This series look good to me. I added the comment for patch4/5. If you agree following two comment, I'll merge these series for 4.11. - patch4 uses the EXTCON_NONE when setting the previous_cable in probe() - patch5, I don't want to use the dev_info on the fly. So, I want to drop the patch5. Regards, Chanwoo Choi On 2016년 12월 19일 15:10, Chanwoo Choi wrote: > Hi Hans, > > On 2016년 12월 19일 09:13, Hans de Goede wrote: >> When the extcon_axp288 driver was originally merged, it was merged with >> a dependency on some other driver providing platform data for it. >> >> However such another driver was never merged, so the extcon_axp288 as >> merged upstream has never worked, its probe method simply always returns >> -ENODEV. >> >> This commit drops the dependency on the pdata always being there, instead >> it treats not having pdata as the pdata having a NULL gpio_mux_control, >> something which the code was already prepared to handle. >> >> Note that the code for controlling the mux_control gpio is left in place, >> as this may be necessary to allow the axp288 pmic to properly detect the >> charger type (instead of assuming 500mA max charge current) on some >> tablets. This will make it easier for future patches to add support for >> this gpio by getting the gpio info from somewhere. >> >> Signed-off-by: Hans de Goede >> --- >> drivers/extcon/extcon-axp288.c | 25 ++++++++++--------------- >> 1 file changed, 10 insertions(+), 15 deletions(-) > > Looks good to me. > Acked-by: Chanwoo Choi >