From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754834AbcLSIWL (ORCPT ); Mon, 19 Dec 2016 03:22:11 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:46191 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456AbcLSIWK (ORCPT ); Mon, 19 Dec 2016 03:22:10 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61a-f79bd6d000000fc6-d4-585798b0882a Content-transfer-encoding: 8BIT Message-id: <585798B0.50502@samsung.com> Date: Mon, 19 Dec 2016 17:22:08 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data References: <20161219001313.13402-1-hdegoede@redhat.com> <585779C1.9080402@samsung.com> <585784FD.3060602@samsung.com> <3cd223a4-f4cc-4343-5ff9-5025d5be19e3@redhat.com> In-reply-to: <3cd223a4-f4cc-4343-5ff9-5025d5be19e3@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jAd0NM8IjDG7OEbR4c3w6k8XlXXPY LG43rmBzYPZ4v+8qm0ffllWMHp83yQUwR7nZZKQmpqQWKaTmJeenZOal2yqFhrjpWigp5CXm ptoqRej6hgQpKZQl5pQCeUYGaMDBOcA9WEnfLsEtY+K8j8wFt/grmu7fZ25g3MfTxcjJISFg IrF52VwmCFtM4sK99WxdjFwcQgJLGSU+r1rBApLgFRCU+DH5HpDNwcEsIC9x5FI2hKkuMWVK LkT5A0aJy0/mMkKUa0gsPvcWzGYRUJWYenArmM0moCWx/8UNNhCbX0BR4uqPx4wgc0QFIiS6 T1SChEUEAiR+nupnB7GZBRQkft3bxApiCwtESfSv/s4IsauJSWLxrTlgMzkF7CTWfG5hnMAo OAvJpbMQLp2FcOkCRuZVjBKpBckFxUnpuYZ5qeV6xYm5xaV56XrJ+bmbGMGR80xqB+PBXe6H GAU4GJV4eAveh0UIsSaWFVfmHmKU4GBWEuH9Nj08Qog3JbGyKrUoP76oNCe1+BCjKdCrE5ml RJPzgVGdVxJvaGJuYm5sYGFuaWlipCTO2zj7WbiQQHpiSWp2ampBahFMHxMHp1QDo8ji4/us RRe8jrY74bHi4TOzNOlzMo4hVacVVFn3zNgYdOJVGGNnQBNH/d2wD+ebH+49ab9Ozyts7+M9 zyoqUg3fvLl8htEsOqnRPfSp3ukuzy2z+v5Vxdlsm7Rv8ucz74KjP4skF36U7tlQssymtMN4 8V7T7YubLzgsM569YpvexPRb8vlBy5VYijMSDbWYi4oTAdyCN5GyAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On 2016년 12월 19일 17:18, Hans de Goede wrote: > Hi, > > On 19-12-16 07:58, Chanwoo Choi wrote: >> Hi Hans, >> >> This series look good to me. I added the comment >> for patch4/5. If you agree following two comment, I'll merge these series for 4.11. >> >> - patch4 uses the EXTCON_NONE when setting the previous_cable in probe() >> - patch5, I don't want to use the dev_info on the fly. So, I want to drop the patch5. > > Sounds good to me, thank you for reviewing these patches so quickly. Applied these series except for patch5 for 4.11. Regards, Chanwoo Choi > > >> >> Regards, >> Chanwoo Choi >> >> On 2016년 12월 19일 15:10, Chanwoo Choi wrote: >>> Hi Hans, >>> >>> On 2016년 12월 19일 09:13, Hans de Goede wrote: >>>> When the extcon_axp288 driver was originally merged, it was merged with >>>> a dependency on some other driver providing platform data for it. >>>> >>>> However such another driver was never merged, so the extcon_axp288 as >>>> merged upstream has never worked, its probe method simply always returns >>>> -ENODEV. >>>> >>>> This commit drops the dependency on the pdata always being there, instead >>>> it treats not having pdata as the pdata having a NULL gpio_mux_control, >>>> something which the code was already prepared to handle. >>>> >>>> Note that the code for controlling the mux_control gpio is left in place, >>>> as this may be necessary to allow the axp288 pmic to properly detect the >>>> charger type (instead of assuming 500mA max charge current) on some >>>> tablets. This will make it easier for future patches to add support for >>>> this gpio by getting the gpio info from somewhere. >>>> >>>> Signed-off-by: Hans de Goede >>>> --- >>>> drivers/extcon/extcon-axp288.c | 25 ++++++++++--------------- >>>> 1 file changed, 10 insertions(+), 15 deletions(-) >>> >>> Looks good to me. >>> Acked-by: Chanwoo Choi >>> >> > > >