From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbcL3Ghs (ORCPT ); Fri, 30 Dec 2016 01:37:48 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:59846 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbcL3Ghp (ORCPT ); Fri, 30 Dec 2016 01:37:45 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a37-f79116d000000e56-38-586600b67367 Content-transfer-encoding: 8BIT Message-id: <586600B5.1000903@samsung.com> Date: Fri, 30 Dec 2016 15:37:41 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andi Shyti , Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Javier Martinez Canillas , Linus Walleij Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andi Shyti Subject: Re: [PATCH v2 2/4] pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433 In-reply-to: <20161230041421.24448-3-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJJsWRmVeSWpSXmKPExsWy7bCmnu42hrQIg61zpS22H3nGarH4x3Mm i/fLehgt5h85x2rx5u0aJov+x6+ZLc6f38BuMeXPciaLTY+vsVpc3jWHzWLG+X1MFkuvX2Sy aN17hN3i8Jt2VosFGx8xWqza9YfR4uXHEywOgh5r5q1h9Li+5BOzx85Zd9k9Nq3qZPO4c20P m8fmJfUeW/qBQn1bVjF6fN4kF8AZlWqTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlh rqSQl5ibaqvk4hOg65aZA/SLkkJZYk4pUCggsbhYSd/Opii/tCRVISO/uMRWKdrQ0EjP0MBc z8jISM/EONbKyBSoJCE1o23bPcaC67wVG++0MjYw7uPuYuTkkBAwkfi97CEzhC0mceHeerYu Ri4OIYEdjBL35jYwQzjtTBLvvvUxwnT83XKcCSKxnFFi5/6JbCAJXgFBiR+T77F0MXJwMAvI Sxy5lA0SZhbQlNi6ez07RP09Ron+3g8sEPVaEof7GsCGsgioSnw/8wxsDhtQfP+LG2A2v4Ci xNUfj8FqRAUiJHbO/8YOYosI7GWW2HGFE2Qos8ABoCP2nAP7QVggVWJTw3+wZk4BG4knK15C Xb2QQ6L1ki3IcRICshKbDkC97CJx7eY7qBJhiVfHt7BD2NISq/7dAntSQmAyo0TX2r/MEE4P o0TjmqNsEFXGEvcf3GOGeJNP4t3XHlaIBbwSHW1CECUeErOfnYIqdwQG6Tto+B5klHj2fQP7 BEaFWUiBNwsReLOQAm8BI/MqRrHUguLc9NRiwwJjveLE3OLSvHS95PzcTYzgZK1lvoNxwzmf Q4wCHIxKPLwLSlIjhFgTy4orcw8xSnAwK4nw/vsHFOJNSaysSi3Kjy8qzUktPsRoCgz7icxS osn5wEySVxJvaGJmaGJkYmhobmRgpCTOu7jROkJIID2xJDU7NbUgtQimj4mDU6qBceqMWLNU 43fzFW9eCr7zbNvWms7tq1yKn+9arq864+AsJdEK4WPLf9vNcJJXfaL25tPmsD2VG9U03vZk n57lce9SytqP0ofjKz8Wh7z2fa15//BCwf7+6j82taaLf38PiZTMkDVNLDqrqLowQ0XwT0hS TOfdg0KG3s9b1k2tOBncVLGwqe5+phJLcUaioRZzUXEiAHUGoaPsAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjleLIzCtJLcpLzFFi42I5/e+xgO42hrQIg0PreCy2H3nGarH4x3Mm i/fLehgt5h85x2rx5u0aJov+x6+ZLc6f38BuMeXPciaLTY+vsVpc3jWHzWLG+X1MFkuvX2Sy aN17hN3i8Jt2VosFGx8xWqza9YfR4uXHEywOgh5r5q1h9Li+5BOzx85Zd9k9Nq3qZPO4c20P m8fmJfUeW/qBQn1bVjF6fN4kF8AZ5WaTkZqYklqkkJqXnJ+SmZduqxQa4qZroaSQl5ibaqsU oesbEqSkUJaYUwrkGRmgAQfnAPdgJX27BLeMtm33GAuu81ZsvNPK2MC4j7uLkZNDQsBE4u+W 40wQtpjEhXvr2boYuTiEBJYySnxdf4QNJMErICjxY/I9li5GDg5mAXmJI5eyQcLMAuoSk+Yt Yoaof8AocaX9FitEvZbE4b4GRhCbRUBV4vuZZ2Bz2IDi+1/cALP5BRQlrv54zAgyU1QgQqL7 RCXIHBGB/cwS56Y8BBvKLHCAUeJozxywQcICqRKtT36xQ2w7yCixat8fZpAEp4CNxJMVLxkn MArOQnLsLIRjZyE5dgEj8ypGidSC5ILipPRcw7zUcr3ixNzi0rx0veT83E2M4DTwTGoH48Fd 7ocYBTgYlXh4f5SlRgixJpYVV+YeYpTgYFYS4f33DyjEm5JYWZValB9fVJqTWnyI0RTo24nM UqLJ+cAUlVcSb2hibmJubGBhbmlpYqQkzts4+1m4kEB6YklqdmpqQWoRTB8TB6dUA+M08VX+ +2dxBIbv79rFl7i4uafOKfLlIUZL8Ru6fx99m7THeUmb5d8m1nkJeXIzljIF3+3sFAtZZr3w 5oy9jbe+LTp5Smnb87/sSle6310Tq1322fjEQaFp+382vNr0+8KlOMlpP29X+WsbtmtxPOac KvTB4BczL88FdvuZX+J2L2H8ZcbaeTtIiaU4I9FQi7moOBEAtXCVFhkDAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161230063742epcas1p31c7c5ced8deadaf397443ab2f331d3ba X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161230041427epcas1p1e4d0dd5e7f9928664c664b7850dbd87a X-RootMTR: 20161230041427epcas1p1e4d0dd5e7f9928664c664b7850dbd87a References: <20161230041421.24448-1-andi.shyti@samsung.com> <20161230041421.24448-3-andi.shyti@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andi, On 2016년 12월 30일 13:14, Andi Shyti wrote: > Commit 5db7e3bb87df ("pinctrl: dt-bindings: samsung: Add header with > values used for configuration") has added a header file for defining the > pinctrl values in order to avoid hardcoded settings in the Exynos > DTS related files. > > Extend samsung.h to the Exynos5433 for drive strength values > which are strictly related to the particular SoC and may defer > from others. > > Signed-off-by: Andi Shyti > --- > include/dt-bindings/pinctrl/samsung.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h > index 6276eb785e2b..e0ebb20ffdd3 100644 > --- a/include/dt-bindings/pinctrl/samsung.h > +++ b/include/dt-bindings/pinctrl/samsung.h > @@ -45,6 +45,20 @@ > #define EXYNOS5420_PIN_DRV_LV3 2 > #define EXYNOS5420_PIN_DRV_LV4 3 > > +/* Drive strengths for Exynos5433 */ > +#define EXYNOS5433_PIN_DRV_FAST_SR1 0 > +#define EXYNOS5433_PIN_DRV_FAST_SR2 1 > +#define EXYNOS5433_PIN_DRV_FAST_SR3 2 > +#define EXYNOS5433_PIN_DRV_FAST_SR4 3 > +#define EXYNOS5433_PIN_DRV_FAST_SR5 4 > +#define EXYNOS5433_PIN_DRV_FAST_SR6 5 > +#define EXYNOS5433_PIN_DRV_SLOW_SR1 8 > +#define EXYNOS5433_PIN_DRV_SLOW_SR2 9 > +#define EXYNOS5433_PIN_DRV_SLOW_SR3 0xa > +#define EXYNOS5433_PIN_DRV_SLOW_SR4 0xb > +#define EXYNOS5433_PIN_DRV_SLOW_SR5 0xc > +#define EXYNOS5433_PIN_DRV_SLOW_SR6 0xf > + > #define EXYNOS_PIN_FUNC_INPUT 0 > #define EXYNOS_PIN_FUNC_OUTPUT 1 > #define EXYNOS_PIN_FUNC_2 2 > Looks good to me. ('SR' means "Slew Rate".) Reviewed-by: Chanwoo Choi -- Regards, Chanwoo Choi