From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753064AbdACQcF (ORCPT ); Tue, 3 Jan 2017 11:32:05 -0500 Received: from mga01.intel.com ([192.55.52.88]:8684 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbdACQbC (ORCPT ); Tue, 3 Jan 2017 11:31:02 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,455,1477983600"; d="scan'208";a="1078754795" Subject: Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk To: Felipe Balbi , Roger Quadros , mathias.nyman@intel.com References: <1479394881-13863-1-git-send-email-rogerq@ti.com> <87wpecxq37.fsf@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Mathias Nyman Message-ID: <586BD208.5020801@linux.intel.com> Date: Tue, 3 Jan 2017 18:32:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <87wpecxq37.fsf@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.01.2017 14:53, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Mathias & Felipe, >> >> On 17/11/16 17:01, Roger Quadros wrote: >>> Hi, >>> >>> Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. >>> >>> If the attached high-speed device is misbehaving, the USB stack typically >>> disables the port using the PED bit in PORTSC. For the controllers that >>> have broken port disable, the port fails to detect further attach/detach >>> events and so high-speed devices can no longer be enumerated on the >>> port. The workaround is to prevent port disable using PED on such >>> controllers. >>> >>> We add a new BROKEN_PED quirk flag and 'quirk-broken-port-ped' device >>> property and prevent port disable using PED if we encounter the quirk flag. >>> >>> [1] - AM572x Silicon Errata http://www.ti.com/lit/er/sprz429j/sprz429j.pdf >>> Section i896— USB xHCI Port Disable Feature Does Not Work >> >> Any comments on this series? >> patch 1 is at v3. Rest 2 are original. > > none from me. Mathias? > Looks good to me, I'll add them to the queue -Mathias