From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939702AbdAFIeK (ORCPT ); Fri, 6 Jan 2017 03:34:10 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:47431 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939662AbdAFIdC (ORCPT ); Fri, 6 Jan 2017 03:33:02 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a58-f79726d000001ac1-f5-586f455457bb Content-transfer-encoding: 8BIT Message-id: <586F4554.6020206@samsung.com> Date: Fri, 06 Jan 2017 16:20:52 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Jaechul Lee Cc: Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Javier Martinez Canillas , Andi Shyti , beomho.seo@samsung.com, galaxyra@gmail.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of ldo23 and ldo25 In-reply-to: <20170106070539.wd3kfhi77pa5ekcy@kozik-lap> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHJsWRmVeSWpSXmKPExsWy7bCmlm6Ia36EwaVlphbbjzxjtTj9aRu7 xftlPYwW84+cY7U4vOgFo8XxlbOYLd68XcNk8XZ/N7NF/+PXzBbnz29gt9j0+Bqrxc1P31gt Lu+aw2Yx4/w+Joul1y8yWbTuPcJu8fLjCRYHQY8189YweuycdZfdY9OqTjaPzUvqPbb0A3l9 W1YxenzeJBfAHpVqk5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIT oOuWmQP0gZJCWWJOKVAoILG4WEnfzqYov7QkVSEjv7jEVina0NBIz9DAXM/IyEjPxDjWysgU qCQhNePExunMBQ1SFY9utTA1MP4X6WLk5JAQMJHYv3oDM4QtJnHh3nq2LkYuDiGBpYwSiyat ZYFw2pkkVr78xQjT8W3zHSYQW0hgOaPEs8uCIDavgKDEj8n3gBo4OJgF5CWOXMoGCTMLaEq8 +DIJas49Ron5LzewQdRrSfw++pkVxGYRUJV48bsFzGYDiu9/cQOshl9AUeLqj8dge0UFIiR2 zv/GDmKLCARK/D7UxQwylFlgKovE4Ss7wRqEBVIlOo+sYwGxOQUsJF5/bGIHKZIQ6OWQ2HPu AivIdRICshKbDkC97CKx6sQ9NghbWOLV8S3sELa0xN+ltxgheiczSnSt/csM4fQwSjSuOQrV YSxx/8E9Zog/+SR6fz9hgljAK9HRJgRR4iHx9Mh/qGWOEgtnQxwqJNDKJPF0f8AERoVZSIE3 CxF4s5ACbwEj8ypGsdSC4tz01GLTAhO94sTc4tK8dL3k/NxNjOC0rBWxg/HfjKBDjAIcjEo8 vB6X8iKEWBPLiitzDzFKcDArifDmOOdHCPGmJFZWpRblxxeV5qQWH2I0BYb9RGYp0eR8YM7I K4k3NDEzNDGyBEJzQ3Mlcd4FFdYRQgLpiSWp2ampBalFMH1MHJxSDYwL89Rec93aeTo2b2Hl g8PtX1Key+yesG/2p4iPl+84/V7saDbPMOp5BQcvm1ZO9ZaNszjK28LM0yIcTk+KLz1q9cy+ cEJpy+uSvieiN6b0ak9lDvA9u/RpZVpXUehDh8ee4ZUx+/bmSb69nJTpysETbCQm8fWJ8Cnp PdvqjO84/57J47xy2w8lluKMREMt5qLiRABkyYDW4QMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsVy+t9jAd0Q1/wIgzU3FC22H3nGanH60zZ2 i/fLehgt5h85x2pxeNELRovjK2cxW7x5u4bJ4u3+bmaL/sevmS3On9/AbrHp8TVWi5ufvrFa XN41h81ixvl9TBZLr19ksmjde4Td4uXHEywOgh5r5q1h9Ng56y67x6ZVnWwem5fUe2zpB/L6 tqxi9Pi8SS6APcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJIS8xN9VWKULXNyRISaEsMacU yDMyQAMOzgHuwUr6dgluGSc2TmcuaJCqeHSrhamB8b9IFyMnh4SAicS3zXeYIGwxiQv31rN1 MXJxCAksZZS4NPUQO0iCV0BQ4sfkeyxdjBwczALyEkcuZUOY6hJTpuSCVAgJPGCUOLCaF6Ja S+L30c+sIDaLgKrEi98tYDYbUHz/ixtsIDa/gKLE1R+PGUHGiApESHSfqAQJiwj4S+z/u5kJ 5AJmgeksEpcObgerFxZIleg8so4F4rRWJomNT3vBEpwCFhKvPzaxT2AUnIXk0lkIl85CuHQB I/MqRonUguSC4qT0XKO81HK94sTc4tK8dL3k/NxNjOBYfya9g/HwLvdDjAIcjEo8vBFeeRFC rIllxZW5hxglOJiVRHhznPMjhHhTEiurUovy44tKc1KLDzGaAv06kVlKNDkfmIbySuINTcxN zI0NLMwtLU2MlMR5G2c/CxcSSE8sSc1OTS1ILYLpY+LglGpg5F+kI9xhP8OBMSdDeGVs1pq9 3w7c2st3syzr05Xgm3Z7ex7mp/7iVLrjLPfO42dmzOQJCtMbi7+9ORZesUG69Ze4ZJruicS7 1/zWHX0ldX3jz3WJMi/+na2SPvHL4MXpKdKv5v/bberCsWrK9IYG3vNVf+1OKZyP/GGgwLPq xffsJjHtA9rfWZRYijMSDbWYi4oTAYw4rQkLAwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170106072052epcas5p4c6661417cd7c3d90fcdbc2f447c0c10d X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170106035913epcas5p20336406863f1029ccf614520f366ddcf X-RootMTR: 20170106035913epcas5p20336406863f1029ccf614520f366ddcf References: <1483675149-32598-1-git-send-email-jcsing.lee@samsung.com> <1483675149-32598-2-git-send-email-jcsing.lee@samsung.com> <20170106070539.wd3kfhi77pa5ekcy@kozik-lap> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote: > On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: >> From: Chanwoo Choi >> >> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. > > Please describe what is exactly wrong and how it affects the > system/user. This is going to the fixes so it needs a good explanation. When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E. [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") After checking the highest version of schematic document of both TM2 and TM2E, there is no difference of ldo23/ldo25 on both TM2 and TM2E. - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. - ldo25 isn't used on TM2/TM2E. (not connected) Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board. this patch does not affect the operation to system/user. > >> >> Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Andi Shyti >> Signed-off-by: Jaechul Lee >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 7 ++++--- >> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 10 ---------- >> 2 files changed, 4 insertions(+), 13 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index 3b5215c..e8971f4 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -504,9 +504,9 @@ >> }; >> >> ldo23_reg: LDO23 { >> - regulator-name = "CAM_SEN_CORE_1.2V_AP"; >> + regulator-name = "CAM_SEN_CORE_1.05V_AP"; >> regulator-min-microvolt = <1050000>; >> - regulator-max-microvolt = <1200000>; >> + regulator-max-microvolt = <1050000>; >> }; >> >> ldo24_reg: LDO24 { >> @@ -516,9 +516,10 @@ >> }; >> >> ldo25_reg: LDO25 { >> - regulator-name = "CAM_SEN_A2.8V_AP"; >> + regulator-name = "UNUSED_LDO25"; >> regulator-min-microvolt = <2800000>; >> regulator-max-microvolt = <2800000>; >> + regulator-always-off; > > Don't add it. See my other patch. OK. After completing the kernel booting, the unused regulators will be off. > > Best regards, > Krzysztof > >> }; >> >> ldo26_reg: LDO26 { >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> index 1db4e7f..854c583 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> @@ -18,16 +18,6 @@ >> compatible = "samsung,tm2e", "samsung,exynos5433"; >> }; >> >> -&ldo23_reg { >> - regulator-name = "CAM_SEN_CORE_1.025V_AP"; >> - regulator-max-microvolt = <1050000>; >> -}; >> - >> -&ldo25_reg { >> - regulator-name = "UNUSED_LDO25"; >> - regulator-always-off; >> -}; >> - >> &ldo31_reg { >> regulator-name = "TSP_VDD_1.8V_AP"; >> regulator-min-microvolt = <1800000>; >> -- >> 2.7.4 >> > > > -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics