From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939762AbdAFIhQ (ORCPT ); Fri, 6 Jan 2017 03:37:16 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:59848 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939658AbdAFIhI (ORCPT ); Fri, 6 Jan 2017 03:37:08 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a58-f79726d000001ac1-46-586f5729538d Content-transfer-encoding: 8BIT Message-id: <586F5728.1010800@samsung.com> Date: Fri, 06 Jan 2017 17:36:56 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andi Shyti Cc: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.hajda@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, Donghwa Lee , Hyungwon Hwang Subject: Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board In-reply-to: <20170106081806.h4y7o57kjbibau6l@gangnam.samsung> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOJsWRmVeSWpSXmKPExsWy7bCmlq5meH6EwbzpHBa31p1jteg9d5LJ YvuRZ6wW1788Z7WYfwQodv28ncWVr+/ZLN4v72KzWDqjj9Xixq82Vov+x6+ZLc6f38BucXnX HDaLGef3MVn837OD3eLnrnksDgIeO2fdZffYtKqTzWP7twesHve7jzN59G1ZxejxeZNcAFtU qk1GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0N1KCmWJ OaVAoYDE4mIlfTubovzSklSFjPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSMf6cWMRfM EajYfqyZtYHxFU8XIyeHhICJxOZ1H5kgbDGJC/fWs3UxcnEICSxllJgweR4jhNPOJDF3+Qeg Kg6wjnk/6yHicxglHk77yQLSzSsgKPFj8j0WkBpmAXmJI5eyQcLMApoSW3evZ4eov8cosWXL LFaIei2JjWeWgfWyCKhK7Gw8zwZiswHZE1fcB7NFBSIkds7/xg5iiwioSyzZu5UZYuhyZon+ b2YgtrBAlETrjz6wOKeAncTpGVvBPpAQ+MouMe34LjaIo2UlNh1ghvjSRWLe2m2sELawxKvj W9ghbGmJv0tvMUL0djNKXO/pgRrUwSjxt/M/C0SVscT9B/egruCT6P39BBoqvBIdbUIQJR4S xxrPM0LYjhJXXrwAB6+QwBMmiU9HNSYwys9CCq9ZiPCahRReCxiZVzGKpRYU56anFpsWmOgV J+YWl+al6yXn525iBCdarYgdjP9mBB1iFOBgVOLhvRGQHyHEmlhWXJl7iFGCg1lJhLcrECjE m5JYWZValB9fVJqTWnyI0RQY3BOZpUST84FZIK8k3tDEzNDEyBIIzQ3NlcR5F1RYRwgJpCeW pGanphakFsH0MXFwSjUwGi7MEP2790WBJR9j2Jzjd4LDJhjNeiH93DMpPf7u3zkHTr29NPP1 JjPnDPv5fxIfbln1Pb9/Bw/7j9k58czSd/r2L5DdqNT7ZG/+hEvZ1xYJdL1mf77x4jTb7bc8 9I0nOTpti+x5tdlF8G5cg6irn23Dop0PHy35HM6jOSFoy8L2LSbVcvKH/imxFGckGmoxFxUn AgCmQvn7ygMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVy+t9jQV2N8PwIg75nmha31p1jteg9d5LJ YvuRZ6wW1788Z7WYfwQodv28ncWVr+/ZLN4v72KzWDqjj9Xixq82Vov+x6+ZLc6f38BucXnX HDaLGef3MVn837OD3eLnrnksDgIeO2fdZffYtKqTzWP7twesHve7jzN59G1ZxejxeZNcAFuU m01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJOKZBnZIAGHJwD3IOV 9O0S3DL+nVrEXDBHoGL7sWbWBsZXPF2MHBwSAiYS837WdzFyApliEhfurWfrYuTiEBKYxSjR 2r2aGSTBKyAo8WPyPRaQemYBeYkjl7JBwswC6hKT5i1ihqh/wChx4eJVFoh6LYmNZ5aB2SwC qhI7G8+zgdhsQPbEFffZQOaICkRIdJ+oBAmLAM1Zsncr2BxmgaXMEt2LbzKD1AgLREm8vR4F Mf8Jk0Tjwx1gczgF7CROz9jKNoER6EqE82YhnDcLyXkLGJlXMUqkFiQXFCel5xrlpZbrFSfm Fpfmpesl5+duYgRH8DPpHYyHd7kfYhTgYFTi4Y3wyosQYk0sK67MPcQowcGsJMLbFZgfIcSb klhZlVqUH19UmpNafIjRFOi/icxSosn5wOSSVxJvaGJuYm5sYGFuaWlipCTO2zj7WbiQQHpi SWp2ampBahFMHxMHp1QDY1/xsjtBzvf73zez/I1l6T1xusjg0qL12qp5X2x38uxkyDb2ddry 5Oeu+dV/szfHtGnFla3ISXaUjN/+42TF2auca2s3bk3k8fnAnlXoturib9/AuiuaUrrydRu+ yi5ftfr/xsdvxSb9mWAsaiBnI3RdMuty2eKZ3OsS3+n+mzfFZN7iRzXPPyuxFGckGmoxFxUn AgA23I9T9gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170106083656epcas5p48a0952d20b2a7cd27dea62f03dd57ff2 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 X-RootMTR: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-4-git-send-email-hoegeun.kwon@samsung.com> <20170106052239.5prkyj3v4x4qcc46@gangnam.samsung> <586F2BF3.8080400@samsung.com> <20170106081806.h4y7o57kjbibau6l@gangnam.samsung> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: > Hi Inki, > > Thanks for the reply, but... > >>>> +static const struct drm_display_mode default_mode = { >>>> + .clock = 222372, >>>> + .hdisplay = 1440, >>>> + .hsync_start = 1440 + 1, >>>> + .hsync_end = 1440 + 1 + 1, >>>> + .htotal = 1440 + 1 + 1 + 1, >>>> + .vdisplay = 2560, >>>> + .vsync_start = 2560 + 1, >>>> + .vsync_end = 2560 + 1 + 1, >>>> + .vtotal = 2560 + 1 + 1 + 15, >>>> + .vrefresh = 60, >>>> + .flags = 0, >>>> +}; >>> >>> how is this working with tm2e? Are these values valid for both >>> the boards? >> >> We don't need to consider tm2e board with two reasones, >> 1. there is no tm2e board support in mainline >> 2. the panel on tm2 would be a little bit different from one on tm2e > > ... this display in the Tizen Kernel is supported by both: > tm2 [1] and tm2e [2]. The only differences are: Why tm2e dts file is in mainline? Seems communication miss with Chanwoo. :( > > TM2: > clock-frequency = <14874444>; > hactive = <1440>; > > TM2E: > clock-frequency = <16523724>; > hactive = <1600>; > > I don't know much about the differences you mention in point 2, > but it's a pity to drop support only because we don't want to put > in the dts the 'hactive', and 'clock-frequency' properties. Anyway, tm2e board is already in mainline so Panel driver may need to identify what kinds of panel is probed to decide porch values. I think there are relevant registers in MCU of the Panel device to check version or similar thing. Thanks. > > Andi > > [1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts?h=tizen#n1284 > [2] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts?h=tizen#n1270 > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > . >