From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933936AbdAIJUA (ORCPT ); Mon, 9 Jan 2017 04:20:00 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:51081 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbdAIJTz (ORCPT ); Mon, 9 Jan 2017 04:19:55 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a35-f79956d000002021-13-587355b8fbd1 Content-transfer-encoding: 8BIT Message-id: <587355B8.2050701@samsung.com> Date: Mon, 09 Jan 2017 18:19:52 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andrzej Hajda , Andi Shyti Cc: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, Donghwa Lee , Hyungwon Hwang Subject: Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board In-reply-to: <5df95abe-0d5d-0c48-2840-5996260201de@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFJsWRmVeSWpSXmKPExsWy7bCmnu6O0OIIgymXLS1urTvHatF77iST xfYjz1gtrn95zmox/whQ7Pp5O4srX9+zWbxf3sVmsXRGH6vFjV9trBb9j18zW5w/v4Hd4vKu OWwWM87vY7L4v2cHu8XPXfNYHAQ8ds66y+6xaVUnm8f2bw9YPe53H2fy6NuyitHj8ya5ALao VJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoLuVFMoS c0qBQgGJxcVK+nY2RfmlJakKGfnFJbZK0YaGRnqGBuZ6RkZGeibGsVZGpkAlCakZmzdNYyz4 JV0x+W83SwPjbrEuRk4OCQETib8rprBC2GISF+6tZ+ti5OIQEtjBKDFh2xxmCKedSWLmrZOM MB3fn39kgUjMYZTY8PEoO0iCV0BQ4sfke0AJDg5mAXmJI5eyQcLMApoSL75Mgqq/xyix7vst qHotiZbVzWCrWQRUJV7/amICsdmA7Ikr7rOB2KICERI7538DqxcR8JFoPP8EbBCzwCRmiS0f +sESwgJREq0/+phBbE4Be4mjF4+DnS0h8JFd4seuXUwgF0kIyEpsOsAM8YGLxJWlk9ggbGGJ V8e3sEPY0hKr/t1igujtZpS43tPDBuF0MEr87fzPAlFlLHH/wT1miN/4JN597WGFWMAr0dEm BFHiIXGs8Tw0uBwlrrx4wQTx/i5miVdvrrJMYJSfhRRisxAhNgspxBYwMq9iFEstKM5NTy02 LDDUK07MLS7NS9dLzs/dxAhOt1qmOxinnPM5xCjAwajEwzvBqyhCiDWxrLgy9xCjBAezkgjv s6DiCCHelMTKqtSi/Pii0pzU4kOMpsAAn8gsJZqcD8wFeSXxhiZmhiZGJoaG5kYGRkrivIsb rSOEBNITS1KzU1MLUotg+pg4OKUaGLtj/rO/mpOt1B48Q+2VQNbiVNk7Mt9fFcc6hp98vvP1 ybA4kZmzlDJdtKKUJir+P3TZs7KN0SJa4X7vUv8DYlKTl9of/tuo96V955XgN56HTPn0WKTc 4iS++zw3Dgl8qZ9+QpyFoay5c9svxvfHLt89NoeZbf5Zqz1qRQtPHNWPFDX+qsm3S4mlOCPR UIu5qDgRAOHQSdfNAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsVy+t9jQd0docURBs0PtSxurTvHatF77iST xfYjz1gtrn95zmox/whQ7Pp5O4srX9+zWbxf3sVmsXRGH6vFjV9trBb9j18zW5w/v4Hd4vKu OWwWM87vY7L4v2cHu8XPXfNYHAQ8ds66y+6xaVUnm8f2bw9YPe53H2fy6NuyitHj8ya5ALYo N5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgHuAcr 6dsluGVs3jSNseCXdMXkv90sDYy7xboYOTkkBEwkvj//yAJhi0lcuLeerYuRi0NIYBajxObt u8ESvAKCEj8m3wOyOTiYBeQljlzKhjDVJaZMyYUof8Ao0d7+gxmiXEuiZXUzK4jNIqAq8fpX ExOIzQZkT1xxnw2kV1QgQqL7RCVIWETAR6Lx/BMWkDnMAhOYJVZ8f80KUiMsECXx9noUxPxd zBJnm+6wgTRwCthLHL14nHkCI9CRCNfNQrhuFsJ1CxiZVzFKpBYkFxQnpeca5qWW6xUn5haX 5qXrJefnbmIEx+8zqR2MB3e5H2IU4GBU4uF94VMUIcSaWFZcmXuIUYKDWUmE91lQcYQQb0pi ZVVqUX58UWlOavEhRlOg9yYyS4km5wNTS15JvKGJuYm5sYGFuaWliZGSOG/j7GfhQgLpiSWp 2ampBalFMH1MHJxSDYytHSW7eKdrfpkVyLFvs9mVOc9bPVh7JTx1Sqx2iP4VPKX3MGP61OO7 lh4PS97ZycUv/F9hxS4NxdpFji1bslZ4B5YErpf1eiy5353L0E80qDFWb+XLeSG1pVf+CFRw 3Un2VPj750naSgb18u/hn7/Pilo11U90xbS7/sX7PPaprRA5WJ6k667EUpyRaKjFXFScCABh xtBc9QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170109091952epcas1p10fec60dd802d0001adec5ff9edb5256a X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 X-RootMTR: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-4-git-send-email-hoegeun.kwon@samsung.com> <20170106052239.5prkyj3v4x4qcc46@gangnam.samsung> <586F2BF3.8080400@samsung.com> <20170106081806.h4y7o57kjbibau6l@gangnam.samsung> <586F5728.1010800@samsung.com> <5df95abe-0d5d-0c48-2840-5996260201de@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: > On 06.01.2017 09:36, Inki Dae wrote: >> >> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>> Hi Inki, >>> >>> Thanks for the reply, but... >>> >>>>>> +static const struct drm_display_mode default_mode = { >>>>>> + .clock = 222372, >>>>>> + .hdisplay = 1440, >>>>>> + .hsync_start = 1440 + 1, >>>>>> + .hsync_end = 1440 + 1 + 1, >>>>>> + .htotal = 1440 + 1 + 1 + 1, >>>>>> + .vdisplay = 2560, >>>>>> + .vsync_start = 2560 + 1, >>>>>> + .vsync_end = 2560 + 1 + 1, >>>>>> + .vtotal = 2560 + 1 + 1 + 15, >>>>>> + .vrefresh = 60, >>>>>> + .flags = 0, >>>>>> +}; >>>>> how is this working with tm2e? Are these values valid for both >>>>> the boards? >>>> We don't need to consider tm2e board with two reasones, >>>> 1. there is no tm2e board support in mainline >>>> 2. the panel on tm2 would be a little bit different from one on tm2e >>> ... this display in the Tizen Kernel is supported by both: >>> tm2 [1] and tm2e [2]. The only differences are: >> Why tm2e dts file is in mainline? Seems communication miss with Chanwoo. :( >> >>> TM2: >>> clock-frequency = <14874444>; >>> hactive = <1440>; >>> >>> TM2E: >>> clock-frequency = <16523724>; >>> hactive = <1600>; >>> >>> I don't know much about the differences you mention in point 2, >>> but it's a pity to drop support only because we don't want to put >>> in the dts the 'hactive', and 'clock-frequency' properties. >> Anyway, tm2e board is already in mainline so Panel driver may need to identify what kinds of panel is probed to decide porch values. I think there are relevant registers in MCU of the Panel device to check version or similar thing. > > I think we can safely use different compatible string for tm2e - it uses > different display IC controller - s6e3hf2, driver will provide timings > based on it. Using compatable string wouldn't be a good idea because Panel is a device not specific to board. > As far as I examined available specs/docs there is no reliable register > which can be used to safely distinguish it on runtime, but the docs I > have are far from completeness. The data sheet I am seeing says a RDDIDS register describes manufacturer and module version information. With this we could identify the Panel device. Of course, we may need to check the register has really different values according to board. Below is the version information Hoegeun checked, TM2 [ 4.908666] panel_s6e3ha2 13900000.dsi.0: Manufacture date: 2014-10-31 06:41 [ 5.035768] panel_s6e3ha2 13900000.dsi.0: Id: 50 20 09 TM2e [ 4.929265] panel_s6e3ha2 13900000.dsi.0: Manufacture date: 2014-09-03 06:30 [ 5.056287] panel_s6e3ha2 13900000.dsi.0: Id: 40 40 14 Thanks. > > Regards > Andrzej > >> >> Thanks. >> >>> Andi >>> >>> [1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts?h=tizen#n1284 >>> [2] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts?h=tizen#n1270 >>> -- >>> To unsubscribe from this list: send the line "unsubscribe devicetree" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >>> . >>> >> > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >