From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758752AbdAJIUn (ORCPT ); Tue, 10 Jan 2017 03:20:43 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:34922 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbdAJIUl (ORCPT ); Tue, 10 Jan 2017 03:20:41 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a3d-f793f6d000001fd5-68-587499571128 Content-transfer-encoding: 8BIT Message-id: <58749956.1030800@samsung.com> Date: Tue, 10 Jan 2017 17:20:38 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: b-liu@ti.com, gregkh@linuxfoundation.org, Felipe Balbi Cc: maxime.ripard@free-electrons.com, wens@csie.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chanwoo@kernel.org Subject: Re: [PATCH v2] usb: musb: sunxi: Uses the resource-managed extcon API when registering extcon notifier In-reply-to: <1483071550-8683-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA02SWUwTQRzGnU67XdTKUkAneNVNfABDZUuR9ajRiLoKD0SNNBjFTRkBbbe1 uzXqg1iJKI0X8qAgeIDRBFG0gqDGIFXEkCiIR4iYoqLx1niRgmfb1ejb9//y+89882VIqK0h 4sgCQcJOgbfSxHDlhWvxUxOzyiVzUsnXEeyvR9UqtrWvkC3tuadki2rqCdbb/0DF3r1USbDV J7ZDttF7BbKDvk7FnAju7NNTKu6Z9w7gvLUlBNdSVafmzh8v5Np7mhTcZ++ETHU2npWP+Vzs 1GHBYs8tEPJMdPrSnHk5KdOSmERmOptK6wTehk10WkZm4oICazAYrdvAW11BK5MXRXrq7FlO u0vCuny7KJnoFQxj0DNJqXqDwaA3Jq+cYUgJIqtxfqCoEzgORW087g8QW8GQxgMiSEQZUcPQ TULWo1GXvz6oh5Naqhmgj3tequRhhwJVf2oCHkCGN45WGWX/JED33c9gaFtDRaFAmV8ZYiA1 EV3vXheyIRWPGi/Xq2XeD1BX926lzCeg3rbe8K6Smoy+fSgOayLot7zsCSeKpCah+4F+ENKx lBldPDKgDukYahGqO+cm5AtqAWor50I6mlqP/B+LwkwENR+V3ngH5Zd1q1HHzi1y/vHIexXK Mg3t2UvLRDR63d6glvVYVPvzoSIUGVFlAHlO/4DysAsgd13bn7aSUd9jP5QzjELvv+5SyYdq 0M5irYxw6M3Q0z/4XHSnqhXKPRwMRj7zSrUP6Cr+q67iX3UV/1V3FMBaMBo7RFseFhnHdL3I 20SXkKe32G1eEP6gCaZm8OV2hg9QJKBHas7uF81aFb9B3GTzAURCOkbz5IBk1mpy+U2bsdOe 43RZsegDKcHmS2FcrMUe/O6ClMMYpzFGg5FhUg1JBnqM5oR7pllL5fESXoexAzv/7inIiLit oMO3b216bEdXpU815ta7t6Xxg8vJJYs9w9Y06IdtMZc7r/dVWqfUux9+7k0vZlr1P5ck6N+k jZuRfNkC8VhW8JTFfGeWH174eHvg+arCce/VlWtu90Ihcl7UwKgmR9Zg/7bOb1J0iWXZ4rhs 963qKateZBDHmp+bWlwDiantUqOPVor5PJMAnSL/G0zQuYm2AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsVy+t9jAd2wmSURBp0PDC3+31nEanHwfr3F xBtXWCyaF69ns9j0+BqrxeVdc9gsFi1rZbbYumkvs8XPQ+eZHDg9NjxazerxZNNFRo9NqzrZ PPbPXcPusXlJvcfxG9uZPD5vkgtgj3KzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvMTbVV itD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbxo/m84wFswUrltz7wdbA+Iu3i5GDQ0LARGLB XJMuRk4gU0ziwr31bF2MXBxCAksZJbrXrmQDSfAKCEr8mHyPBaSeWUBe4silbJAws4C6xKR5 i5gh6h8wSlzunMgKUa8lcfvobWYQm0VAVeL3+zYwmw0ovv/FDbCZ/AKKEld/PGYEmSkqECHR faISJCwi4CmxZmMj2A3MAqsYJdr/XWcCSQgLFErMPP8U6rhZjBLzd1xjAUlwCrhKTDz2lnkC o+AsJLfOQrh1FpJbFzAyAw1NLUguKE5KzzXMSy3XK07MLS7NS9dLzs/dxAiOzmdSOxgP7nI/ xCjAwajEwxsxoThCiDWxrLgy9xCjBAezkgjvw+klEUK8KYmVValF+fFFpTmpxYcYTYGencgs JZqcD0wceSXxhibmJubGBhbmlpYmRkrivI2zn4ULCaQnlqRmp6YWpBbB9DFxcEo1MHL/3lcR 4PB5x5aNQraXl19VrD4p5dESlX3E7NMnZiOj38c5s9ZWPtY61JDyhf+33NvbHbn7Zd2DT/qt 7Zy6wffe2Qt2AU1dv9/9q7cPnb1ze/OLWEtnhY2u0onfjZbHPm49cOuJqZ+wqZzuXfm4wjPv Yy/su+u/vdezv1hbcYt9/9qp7DYph5RYijMSDbWYi4oTARWNNp/kAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170110082038epcas1p4f8a5e317751e658a5b0dfa81e88f9c76 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161230041914epcas5p24826e70fd5de710818687e55579757ba X-RootMTR: 20161230041914epcas5p24826e70fd5de710818687e55579757ba References: <1483071550-8683-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, This patch got the acked-by from Bin Liu and. Could you please apply this patch? On 2016년 12월 30일 13:19, Chanwoo Choi wrote: > This patch just uses the resource-managed extcon API when registering > the extcon notifier. > > Signed-off-by: Chanwoo Choi > Acked-by: Maxime Ripard > Acked-by: Bin Liu > --- > Changes from v1: > - Rebase this patch based on v4.10-rc1. > - Add acked-by tag from Maxime Ripard and Bin Lin. > - Drop the phy/power-supply/chipidea patches. > > drivers/usb/musb/sunxi.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c > index d0be0eadd0d9..2332294dee0f 100644 > --- a/drivers/usb/musb/sunxi.c > +++ b/drivers/usb/musb/sunxi.c > @@ -251,14 +251,14 @@ static int sunxi_musb_init(struct musb *musb) > writeb(SUNXI_MUSB_VEND0_PIO_MODE, musb->mregs + SUNXI_MUSB_VEND0); > > /* Register notifier before calling phy_init() */ > - ret = extcon_register_notifier(glue->extcon, EXTCON_USB_HOST, > - &glue->host_nb); > + ret = devm_extcon_register_notifier(glue->dev, glue->extcon, > + EXTCON_USB_HOST, &glue->host_nb); > if (ret) > goto error_reset_assert; > > ret = phy_init(glue->phy); > if (ret) > - goto error_unregister_notifier; > + goto error_reset_assert; > > musb->isr = sunxi_musb_interrupt; > > @@ -267,9 +267,6 @@ static int sunxi_musb_init(struct musb *musb) > > return 0; > > -error_unregister_notifier: > - extcon_unregister_notifier(glue->extcon, EXTCON_USB_HOST, > - &glue->host_nb); > error_reset_assert: > if (test_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags)) > reset_control_assert(glue->rst); > @@ -293,9 +290,6 @@ static int sunxi_musb_exit(struct musb *musb) > > phy_exit(glue->phy); > > - extcon_unregister_notifier(glue->extcon, EXTCON_USB_HOST, > - &glue->host_nb); > - > if (test_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags)) > reset_control_assert(glue->rst); > > -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics