From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757970AbdAKCQV (ORCPT ); Tue, 10 Jan 2017 21:16:21 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:17287 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753248AbdAKCQU (ORCPT ); Tue, 10 Jan 2017 21:16:20 -0500 Subject: Re: [PATCH] scsi: remove useless acpi functions in the head file To: Aaron Lu References: <1484036044-9514-1-git-send-email-guohanjun@huawei.com> <2e748ead-9118-9a00-d9e7-711fc2cd85c3@intel.com> CC: , , John Garry , , , Hanjun Guo From: Hanjun Guo Message-ID: <58759557.7060405@huawei.com> Date: Wed, 11 Jan 2017 10:15:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <2e748ead-9118-9a00-d9e7-711fc2cd85c3@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/11 9:50, Aaron Lu wrote: > On 01/10/2017 07:44 PM, John Garry wrote: >> On 10/01/2017 08:14, Hanjun Guo wrote: >>> From: Hanjun Guo >>> >>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support") >>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(), >>> but forgot to remove them in the head file, do it now. >>> >>> Signed-off-by: Hanjun Guo > Reviewed-by: Aaron Lu > > Just out of curiosity, did you find this by some tool? If so, can you > please let me know the tool name so that I can avoid such problems in > the future? Thanks. No, not found by tool. I was working on a patch set which tried to introduce a new acpi bus type [1], so I greped the usage of "struct acpi_bus_type" then found this issue :) [1]: https://lkml.org/lkml/2016/12/31/40 Thanks Hanjun