From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760303AbdAKKrD (ORCPT ); Wed, 11 Jan 2017 05:47:03 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:53945 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759921AbdAKKrB (ORCPT ); Wed, 11 Jan 2017 05:47:01 -0500 Subject: Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations To: Tejun Heo , References: <20161229221115.31995-1-tj@kernel.org> CC: , From: Zefan Li Message-ID: <58760D09.9010508@huawei.com> Date: Wed, 11 Jan 2017 18:46:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20161229221115.31995-1-tj@kernel.org> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.236] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/12/30 6:11, Tejun Heo wrote: > Hello, > > On the v2 hierarchy, when controllers are enabled and disabled, other > ->*attach() callbacks of other controllers are called spuriously with > the same source and destination. While this isn't critical, it's a > bit nasty and can lead to temporary double charging on certain > controllers. This patchset fixes the issue. > > This patchset contains the following three patches. > > 0001-cgroup-cosmetic-update-to-cgroup_taskset_add.patch > 0002-cgroup-track-migration-context-in-cgroup_mgctx.patch > 0003-cgroup-call-subsys-attach-only-for-subsystems-which-.patch > > 0001-0002 restructures migration context tracking so that extra state > can be tracked easily. 0003 fixes the spurious ->*attach() > invocations. > > This patchset is also available in the following git branch. > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-avoid-identity-attach > > diffstat follows. > > kernel/cgroup/cgroup-internal.h | 69 +++++++++++++++-- > kernel/cgroup/cgroup-v1.c | 10 +- > kernel/cgroup/cgroup.c | 161 ++++++++++++++++------------------------ > 3 files changed, 135 insertions(+), 105 deletions(-) > Acked-by: Zefan Li