From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751458AbdALLLz (ORCPT ); Thu, 12 Jan 2017 06:11:55 -0500 Received: from mail-sn1nam01on0040.outbound.protection.outlook.com ([104.47.32.40]:50994 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750777AbdALLLk (ORCPT ); Thu, 12 Jan 2017 06:11:40 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=George.Cherian@cavium.com; Subject: Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT To: =?UTF-8?Q?Stephan_M=c3=bcller?= References: <1484132211-917-1-git-send-email-george.cherian@cavium.com> <2395769.pOGQxxvRjM@positron.chronox.de> <587616D1.6050503@caviumnetworks.com> <1522639.tMShRcNLPc@positron.chronox.de> CC: George Cherian , , , , , , From: George Cherian Message-ID: <58776428.1060308@caviumnetworks.com> Date: Thu, 12 Jan 2017 16:40:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1522639.tMShRcNLPc@positron.chronox.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0058.INDPRD01.PROD.OUTLOOK.COM (10.164.136.158) To BY1PR0701MB1708.namprd07.prod.outlook.com (10.162.111.14) X-MS-Office365-Filtering-Correlation-Id: e8cd17c6-0f81-4545-5b7f-08d43adbad03 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY1PR0701MB1708; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1708;3:yMEIJjJ2k1jKhWB8OzpFzMCGRoJVo2UslGc5ah2rYxmwkY/sRpAzq1wB6EA5btSWD4BXas+yV3grMOpL7LDOA3aLtRt+AHz+OLbY14jac1zTmBsyY9ClUcBInaYf5L2p3UfVuWNUtT3wVG5RezJ0PqPBb+haVyT7IySCGuU0YryOk3ttgdf02R66bWYufDHDmPGDOMQMilOsg1yhjQoVhUzoyTUvCUeQMKXpIJh9aMbL/qhRrD2cuUdMhHdEwfdECsde0RPCdUjFtyatDmEvrA==;25:Xdoy5ZRdICWym+eyGq5duitmUS9jUycoT7smWi2VQFLvRZAGF42TESDrOdMCsgWy1fszb5wnennAmgvLeneJHdiWnBt09ikjJiugC8T2SSCGlwzoaC2kYq44cphwNiJWrGn8J2kOzd9UQN1TbInVQRz6gmz2REGTvtJuRIp/9aYtHpgDV4STfNmQPCm+0HAr7TBavenzZJ+m+abQrVOpmt/ESIBg6lYuseRNINOCVfWszC5LN4zL8BtaAWIY2I00y7IWpF8aWsbFQAM289YjR/N+K2ehohXBHoxV4pNaldFmzyWbL7tzVc6lDSfwdq3T7KmOA6KED4ZS6u6BJQQZAdATGh1PmJqSVzUV0nNkx1SccLrRZhtI1mVlGao9Fra+e0jkPTYB5ZIWkW7y+cdNleIISdv1GHPHYxH3UIA0sasg0CtvIgX30zhaBVVbwC3D8m+PPLOQt4vSpiV9XJVxdg== X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1708;31:DjkluI8YEn42li0H1lHfSVZ+nJjK4X+r8m0DGBaeYAVwpVszv81+9CpefjAM00grw1UzZhMLVRcOFB96HO8Q8npnSK9N02OVSt2KXUIcoVaLpWuBnlioAkd9Irm/ur2aGvXw+EjwCGO+GRDrlASvax4ZYuzkd9yJ6dQei8xN491ps8ad3+ktJK+V4WbhQK6T1prOlLdic4knh4MaIPIrYy38cc9vCTdHoc7FbfLKV9pTLWaPCJbRdHtViEba974z;20:lmfO+udpASa6XZQV3XNSENNpA3x802gqChy0s2P18HZDYf7P3u7f/v1pYJGmicfXzlfvMdfK51D0wT5uvtT8WFrV19H53E4qUI1tQg/52TQFN7fJH0rXp2MVgYsW9GKA+KdcxgwtyC8gc9VRqy6Z38kA9VeQge8rjxIZHbDooySriO43oL6lNhbnMNQzvzzNIsfqUGA6h8RDv5WUgTIJ+aTCzhx3Ilno+LGWFvJ9j3jP1Vt7RAXf63+FWmm619pQ7Hs08hbnAB5DoPOOPJouZc5b7INPLrwBAoBZxQDmO8MsZ2RfFwH/7niONWEX8sC/tKcv+mA7WzSunhCDPfMvlsgfVphYqY/Pq3x68hySjgL5T9cDe7xonedHstl1WjzNRPUqoICsESIPRO2lV8XtVahIO1QGGZP1i3j05VlOMo3EISrrQN2R4PoWmEuRGGd+OdOdIJIne466Q1Yn8RMBRXvyvagrqeTFdo1YXABE1PXay/k/iAyHDCAUPftP6I5VsARXooA4Vo7pBSOX+H7BqJWQMQGC/H0IGiSSstWR71F2du6ANdhuNJEMKE+3FBANkH+6gedb5a92bZqJJytz5MbprPoIzzLydfxqrWgBN5Y= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:BY1PR0701MB1708;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1708; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1708;4:aGljjamji+FOdH47wyKy7TB65dh0E+VBLUV7i8iDrYQQONJ/6Lu9CoHnlVJVGNlfA8Ytfu0BIugN468k4BSXyVLf2IznkdBmyCY/9Vt12h5QpU27GyAp6jKRUXB8DM1zBS5h/vMoy1MTw2LASHkO4JL5tQhEqDw6Ku1xPwpx1v3TB45YNxwBpYanebpslT1MCCGbXlcq3KtTYK1yjn+vSHq49F9k5RCkrQvOqe8hClPGFfhbxPs9I2Tngku3RrwfRsahUmGmSENkHejq8FmaXY/MNKcLXg2aCba++UoYgzmoHjoftgQRtNnmCs48Z9Gj2VnmG+Inks16dhoGbEzYqB9/S0Iw1vopPNllb3ILgNumvOoWi+i+a7CjVtsLdG01xvHMA3bdpiYeXyOeGA2jFA+Bzb+Fdi3Ab/N8uLMeR9XAmf0bHyB7gqyb23ILM0zLG4Tx4g+M+LlyjA+Qjr0wzasBIXiMCFK9n434K9riSXcN5WxPdKKeHBWylHHiN597LPaZV0KkUaUblEolBCaeQN5FFsH+DdgGcbgLS25ivLV35XojOUFk3oFo5cpzuGVJl3+32ge2nwA9oojOLz5THQ== X-Forefront-PRVS: 018577E36E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(189002)(377454003)(199003)(24454002)(189998001)(5660300001)(83506001)(105586002)(2870700001)(97736004)(106356001)(90366009)(4326007)(4001350100001)(6486002)(25786008)(66066001)(65956001)(65806001)(77096006)(47776003)(110136003)(92566002)(6916009)(54906002)(229853002)(38730400001)(42186005)(39060400001)(2906002)(42882006)(64126003)(2950100002)(6666003)(7736002)(68736007)(117636001)(59896002)(93886004)(122286003)(305945005)(6116002)(54356999)(50466002)(50986999)(65816999)(99136001)(76176999)(3846002)(87266999)(101416001)(8676002)(23746002)(5009440100003)(81156014)(36756003)(81166006)(7099028)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1708;H:[10.167.103.57];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR0701MB1708;23:uQ1Fp3cB2/YI56+OuUcoR4KjcdvnrIC6M84?= =?Windows-1252?Q?Q7NgGyH/msBuCnPfU9jjSDv+cU3uw2uuqZhFMSt3J5sOLR+LW9H/WLSx?= =?Windows-1252?Q?ZceGA/Wn/5Jc2vSswKE1inj6PzmwB0YQlDH3Al3VtSjsI+MyaWhJidUe?= =?Windows-1252?Q?lVX5dujmZDQ7lUjxUTrSmBrYGrKy6dSrB9olbyKEIziQXmptVoXutyW8?= =?Windows-1252?Q?CfG/523jx42BqjWaX69T8XTk4VXiSQAUYhlFN/gWlA7LOsdeCSOJMsYG?= =?Windows-1252?Q?tvAZTV3WEvELObqkjmgQ0G/xU/2/IOs0lYsFt50peM+W762R28C5t6jc?= =?Windows-1252?Q?PLCT8Tw/7miaH8TqCLLlEUkOs4EmqVXHZxeG4vr1MV5MWdxwCVvTT+t1?= =?Windows-1252?Q?luJHQ1h9TDC6E8YnUwSLgMbOYfW1o2jmQonIvWKex97YjzmKpnqXCCgf?= =?Windows-1252?Q?FzAuOQZmYNx02H3wSmTYeTQtcQXMs6OhYaIgTiHcmh/ECRuFYaMucAA8?= =?Windows-1252?Q?iw9Lh1yurIlSbPTHmWN/wWWunRoYotViAbW5apq1v1wZgSTVPePfIwvb?= =?Windows-1252?Q?5/6Gj1gLuuHoy8lGHnt0TOMpK+OTD7pPEyInc1o27p78WH0RRs2cya/2?= =?Windows-1252?Q?IKnHGYW9hRMXyrS+VKUkN3ghW4HAAtO5fP4NzRKiJsG/nQdSI0OBtfaF?= =?Windows-1252?Q?9ZWQh8JlS9yYQxRT+cjMJK7moiBBrBSNVACxMa6hh4sM1aXaHbxORzQ0?= =?Windows-1252?Q?9BXS+PwRrchquQXQPFdpM77vSltxeAh/+pSFbD/Dx7iwk8m29IpYaBEv?= =?Windows-1252?Q?PuSi7RLGmxQpzl3bhLdxx3RUCDzzFlV4ygjTY/m/qQ0ZNI1woNFsRP0B?= =?Windows-1252?Q?9WzJXGAvCyHqJPyjVZfWFasVxAI5wAX6/z/EW/jhx9uS0h57VsPCgF52?= =?Windows-1252?Q?6rhQHM9MWUe8pxIns/9TyUm/73t+zfCvj9x+Z6hlMAZG2JUizIKXyu5s?= =?Windows-1252?Q?3pBsOXtn+FGID8WOZYgBuxe2stEcy9iBNBs/qESDYKVnrYaAFiioZpPt?= =?Windows-1252?Q?ar5X97oMNxHy1dDNzj8zsob7pfsJtcVNxeLXakQuiDHZpT0PHXells5W?= =?Windows-1252?Q?eilldkS9UssmR0G/ScpYxJF8hxdVUL8r74VkU/WTlajLJJkdlazMKpdx?= =?Windows-1252?Q?0IUXCKb/9QVqgqLuEZCSwe9J4z/atvEqSpOBsoNm8Ap/ssiDtuatZwJf?= =?Windows-1252?Q?3juB41Gl6M9HG9bVNALuwbqvqrmKPdQ0vCzHsg8j95Ni3jdIN6n5yr6f?= =?Windows-1252?Q?UMUzRK9rprf4FOFSxDoStuosZIEb+gv/MqJ2BcQLOog9/o4Pr2C/v6O5?= =?Windows-1252?Q?hhT0H5hX136kaXk5DuVwt11omD/uzGgqOtccAme5GVtDsSmNu9J1Pc1H?= =?Windows-1252?Q?wwXQApZw+nNqtmHfcebQDJQYz1HHWEQTODwHQrgaeZxoAbA6yOC0frqH?= =?Windows-1252?Q?9W5hl7RRbpfGIWoaLjqz11z/aKJR/Pek1qb1MrFljiO1iGQy4GaAuPfM?= =?Windows-1252?Q?9G/asZDTcgD1rDl48H4mbog0bS0FRIzVaJADGefhd98vrn8lWmt1WLdO?= =?Windows-1252?Q?SCX6Ci/8KtGuEfxvNqsLh4JCiiVlP+yFuC6+U1uo/jXT2?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1708;6:Cmhpiq+8XDIYFjk6PTw1I8dW12j3LXvGFzBWrZHq8/NixKXiFUaPN1NIut43Kt+pwU9lnE0MtsoT66AQjFzPhIUeqfeHJeveVTkZmswgFBgNmimQZyVzF2svUPhxHqXReoYaKKBhCNIY+S0X2plmFpN4UaJubUNLL0aqx+Hug/dcEZZ7VFo8I7dujIhggAQVBLW0OVxoa2H0CqwD9ytGn7ntBk/s02SeV3yU6XxJPqPM9G1baE/imWj76G9m0OhpWEeaQ0jygDsjmeynWQYZp8B5dgr+zUPXnDWiEm2Ivw1eKoWr6peckeizsDlGgI64169rMT1q4meOC+/OEuAhOkIstl5ht3+NDYwECPET7O+qGJ3V82NVFyf24Linube7SWHuvP5O9WWhdQEi9VnMCypwfTbS+M9361rmupCnxCo=;5:f/uIQlrm7EWCqu5EOuT1sFK0UvWa8fcfxovtrASaSdU2UE22xAl9aVXIZwbn8QexKZUOkFBGaZSH/2fwL+9s0tRYJs6X4I0vCF7bm6ySsngOqhbnwUoHd/tIOQtnee+opbjVSs2U7GoshSo+j5c7G3Wz6qvJfCPajcDCCJL9shY=;24:VPWXQUoqCOxIFktQ0dBidTU61o8JXJas7jY9AxPR29OBMExHZ17Zw+2eaRllfUKTRamJSfAOHflAV8VIEJCawhXu1qhtrejG7NY0JSkABwI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1708;7:2otkjzVKn8s3wK+j0NnIOsxCd34pcygtGT3OIky8keGQXSyh/QvXW6882Ijitdw+yvVlgFLy3GRXyH95Dq//T1jbnWLA171ev2Wyv7ItJ/1JRJhqOc5dtkyCeOJlAVCLWtWHgfBH6DUCYkrG1oiNScjpnJtvIOv6C2OfODr4v0qfT2L+nQhrvpruxSGDTubFkO0Igj/xdGStE6gic01adlWU+/Oec4rzdwdjgm+q4uBpZ07hSVKCY4qgehAyAipfmu4rUxkJR3+m5tUEBAsGFOmxYff/PDvfvV9PPT4SKfQhsFlJbu0/g6QXgCWnwoOlS5D5UqLUZa9sBVBUceOuZgHVtvSjrCkKflllMYMObFU391GqeXfbS96fqSKJGwynxOYofs5ns8Q+lP/QoBuwzPAPvzw+IIvfqWbAXeajpDz7fmM9QV23iMqhzcgJG3wgim4BWr1PzV6/RzHJp8r/OA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 11:10:50.9263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1708 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephan, On 01/11/2017 06:09 PM, Stephan Müller wrote: > Am Mittwoch, 11. Januar 2017, 16:58:17 CET schrieb George Cherian: > > Hi George, > >> I will add a seperate function for xts setkey and make changes as following. >>> ... >>> >>>> + >>>> +struct crypto_alg algs[] = { { >>>> + .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC, >>>> + .cra_blocksize = AES_BLOCK_SIZE, >>>> + .cra_ctxsize = sizeof(struct cvm_enc_ctx), >>>> + .cra_alignmask = 7, >>>> + .cra_priority = 4001, >>>> + .cra_name = "xts(aes)", >>>> + .cra_driver_name = "cavium-xts-aes", >>>> + .cra_type = &crypto_ablkcipher_type, >>>> + .cra_u = { >>>> + .ablkcipher = { >>>> + .ivsize = AES_BLOCK_SIZE, >>>> + .min_keysize = AES_MIN_KEY_SIZE, >>>> + .max_keysize = AES_MAX_KEY_SIZE, >>>> + .setkey = cvm_enc_dec_setkey, >>> >>> May I ask how the setkey for XTS is intended to work? The XTS keys are >>> double in size than "normal" keys. >> >> .ablkcipher = { >> .ivsize = AES_BLOCK_SIZE, >> .min_keysize = 2 * AES_MIN_KEY_SIZE, >> .max_keysize = 2 * AES_MAX_KEY_SIZE, >> .setkey = cvm_xts_setkey, >> >> Hope this is fine? >> > Sure, please do not forget to invoke xts_verify_key. Should I be using xts_check_key or xts_verify_key? > > Ciao > Stephan > Regards, -George