From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbdALLVm (ORCPT ); Thu, 12 Jan 2017 06:21:42 -0500 Received: from mail-bn3nam01on0044.outbound.protection.outlook.com ([104.47.33.44]:25187 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750819AbdALLVj (ORCPT ); Thu, 12 Jan 2017 06:21:39 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=George.Cherian@cavium.com; Subject: Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT To: =?UTF-8?Q?Stephan_M=c3=bcller?= References: <1484132211-917-1-git-send-email-george.cherian@cavium.com> <1522639.tMShRcNLPc@positron.chronox.de> <58776428.1060308@caviumnetworks.com> <1970611.axXSiX4HVh@positron.chronox.de> CC: George Cherian , , , , , , From: George Cherian Message-ID: <5877669A.3070101@caviumnetworks.com> Date: Thu, 12 Jan 2017 16:50:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1970611.axXSiX4HVh@positron.chronox.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0047.INDPRD01.PROD.OUTLOOK.COM (10.164.116.147) To BY1PR0701MB1706.namprd07.prod.outlook.com (10.162.111.13) X-MS-Office365-Filtering-Correlation-Id: 267aff55-0774-46ae-20fd-08d43add2beb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY1PR0701MB1706; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1706;3:hj0pI5siM747jO6HiD/B2MlLAjZQ1joAfjTh0mwMqGg7chHDK7GMJ5JlB/iaGFxq02hLAIprrvHM15zGlUqQFVn1QdMswacWfWB99P1jjMGM+83pLHjO9LrW1c7uO4zxLFR+NiJpPgf/lgR2psnhWs/WIOGnngoKQIvoPIVYfqxZk3x52ZpoxKfos3oQqwQks5WVtw5rLCLZsCcZFpoEn2mUJUBdbjgbYLSPrSwrMo4zppMHguFpTEFmIy+IGWntNPWbI67i8l+hYwNiIb0how== X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1706;25:8ijTaQTtbmJND99x9AuQDfUtMTHxygV1xLVEBLFTZhPZNDcoaJ+pvpe5UMiC4vAgXuktd2lzYnDt6biAU7cjA+cXXW0YylCFie58Pxlwnt0Ky3uBh0ndMm7nnpQf3VrA+7+x9t+Q9xSK9MFizDs0OLIOhVxbyO1i3KODc8k66q+9YFYaTjmpmpwahtZbo8HPBt6j3nBRznJn4FmAtoCGwuD9TC5zmZRKWmC0efuMOFNQox5LU/K5o0UebvKds9a2dyuF329JcC+2zdzgAbQ6u0SSanwalVcguVYftujzpvb4xZIyKFaeMF0bIwMs9RaZlQYuuroTxYIeORaO4ni87bH8o3UOYqniY1VAc90DEqfmmr+8J7xRq1vdDPGhyM8o4vbDCFO4jbOUzYX/wy9rqg3HX4ml6RYRLRZcUHRQ0LAGJDJhrSkNVovkK5rIjLKwoGyDAauIbZ58vMOM7vpm+qh7NGaa4RMdRz66eoVStpGVsY3djX7lOKr0Hy6IN8x+NW/GgOU2e4SMtlSQdcVrI+CJMlMARCCVAWjgVAJxVQYY5MgZKzDu6VXpx/sP4mldq54lzzJwlAXVdNn8mBO/hCvTNHGXUZmVqGhBkJOpVQyi/d9z9zHFZnX1lZ2Ls59P0tuGtv0SkkySYlMvvC0VuIlG5CDDFAnQvs0VGgWCL9G4ZNxpxJX2V6AxxxlvD3XVk9TlzutAnS/22P9l+XtFnc+y804u3e+b4d3870ptB8/nd47M49AIxeeMJNyOyWlFgLtT6J3RQrlrKAHbqCdz1reIKHm2DskBv8sR/sEQsuI= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1706;31:EUZ/0nk0YosPAXuOst0dzG1fKmYqteV8ykCdLFuU4qKGNdgbiwOl7X8k2C0H9A/zUOGd8aWklF37DeEEgYYqtbQSXadvJ47kIj9AF8f8O1Ti9SplrLR4E7OHd2Y14wdcxOLjpzfMabtVic9NVY3RNqAH+WoRUIJpEf/HyvcZ7Yk4PQlg/s42Sx5uMSiTdtxlq0VhuODzmdd10jg2BkkYR3KstLdydZJbS8LJjM2PvEZDluGrFeFnucLz8Dx13ATy;20:auXdVhQNoUHE4yG5d7ecBrFP1Ef77ffFNxsdTPz/vrkzItKBzEw7ajR9OqdGNZW0SeefkD7hGlEL9sMI6nRD69rO3eED/qr5UXLOfXyy17X4kJmjpzKBdsBTB3QfSt5E3t4l++mleh/iNY0DRlxMzkO3Wo5ITykGhuu7Jk4xI7nJ4aL25ILD7O3r0pwZjBz5RBoXMNxFR6RBvKbtx5fLk7eAHiqYWiQSbEh9Z8ERcrw5DsEd1ZdTOHZ8ubCxe2nZAnXZYZNTxP3nt8to+89DziiQbnz3PijNGRxEdjhbjYeE3jD0S0bVB6yGrCTMsCnMfqpf1rE3WgxGcPPMlrUT9MItORhuYU/zNM+BeDJ1fuCCoGuqYgUQ8Y+g1aCnYDXpL3DYUEgWTQZtoCpm8QthDk60CgeCSoMruDrLmYjyQwi80hyrCcTUDSRW8zveLJpGE/MbZPzlFNKBMJgIpr7J+tG2TdyYAdkuMLqUoNoE0jw+1puOLdgww0X/pBaGFgYi9n0TcrTPJzL6+v8LHUPzSgssEJzwPlj8pF7IkZl9OI2gernUCUUn+Qfgo/Kthncf4YI8cp9KN8c6UEdo86Hak1iUGG1xXgmWNlH7bAq14CE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148);SRVR:BY1PR0701MB1706;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1706; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1706;4:yjUJd+NgdmUnADslRA8zoBNqQC11slgcriMXD/b3NBYJ9LDX5W3vr8yz+/EXBNC4XtuD8UhogP2pScnUVdfGZwsc+0V9D0JPf41VVuKU0pq60D0FVdhc7oitgrQCPjQDg0DC4iEwTJN5VQ0R7zSGG4VVDAK5OAwYMfnDrVoYdcOv9zallhpSfZkwPnNT2iexG7hG92eTTguaU6jHuT8DfjXCtLda8C0cs4AQ3e1bfpu9wsXfYM1aXrEz+xaUf6I2kjkpFjjnOBo1JuJdguEHo5KJYtBGsYm/zqSC0BvoND72eQgP6WAV3BEd40EbNOAx7b4B0dKRLwwaLrjG/BewkkupBb32rnonWzCpP0YgmuZj9mu/nY6uKyPiLgSaHKsQbTRaePLEkxrKor92kRV5rWqaFrfiQRRP70IIfp8yxDfYuosQiDfEgSWv9N/6GG6l5sHMSjDITdoBKKhevJk8G+OF+Rroj5Zp5J7wBvceyrSJcA15t/MyBCTLrQ0dIx1I6UiVlIewv8YsD5vy6d3Gkzkixgle3Izj3xj8kZ4cRVaDiaOz9ryrPa/s0B6uKdVXb0pv15DpANe/5h08XNQgtQ== X-Forefront-PRVS: 018577E36E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(189002)(377454003)(199003)(24454002)(5660300001)(33656002)(2870700001)(4001350100001)(54356999)(97736004)(76176999)(92566002)(50986999)(64126003)(99136001)(4326007)(2950100002)(105586002)(68736007)(345774005)(106356001)(80316001)(83506001)(81166006)(36756003)(110136003)(8676002)(42186005)(42882006)(81156014)(6916009)(6666003)(39060400001)(59896002)(47776003)(189998001)(6116002)(93886004)(54906002)(50466002)(65956001)(66066001)(23746002)(65806001)(3846002)(77096006)(101416001)(38730400001)(90366009)(6486002)(229853002)(25786008)(2906002)(87266999)(5009440100003)(305945005)(65816999)(7736002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1706;H:[10.167.103.57];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR0701MB1706;23:ib/d3u5YSrhMJqJ+R1Pky+JH5eWNv8Q9Q3z?= =?Windows-1252?Q?LaQoPfMmGSCqg0qZxqdZw6PzWmxRVrdtFaIQZm0T82wctprFsYEvrPrp?= =?Windows-1252?Q?1ww5O6WV9eTbkc6+Hm/TD/u4a/e/cdylBDjC/yUxLnnRXLU9lD4FMhMC?= =?Windows-1252?Q?TqCF59iOgHtriYFfFQ/P741NdMfYIFEOibQJcnykav0O2HmjYmsQ8erh?= =?Windows-1252?Q?fPk4jkZC1eWtB0Cz2sXANsYsQ4CsqMjMhRQ+YrsOB3al4jwMG84uj3rU?= =?Windows-1252?Q?VhOGklYhiTQ3T9etoSpUWYVJZmxEeHwyaZF87W9nc6S25kGhaavrgOnD?= =?Windows-1252?Q?sMpFRHeAR791Gn820IA1KxNIE71nfyAbKcd8Auzsq0HKWO001O8v+Mca?= =?Windows-1252?Q?CKnR2CAyH6Nuoq2b+hcYrvOJbadZvh2i1QTw4vwGqYvgX8E7UPC5vkOO?= =?Windows-1252?Q?HULyshZTZ8UIrN84fkuy79qwBL8AIANimNNnsXBjBzFHRdchptNZyGPq?= =?Windows-1252?Q?kBRzef41mnH7rybhs2Fehg4wO2JI9OOoB0i60Q6BIw+s2cSS14s3ToxM?= =?Windows-1252?Q?KHzdczQoP3FfyJ2EiPuG5H7D+SeWJw3IhZ3/xU07e8u2ABYKggR2cF2V?= =?Windows-1252?Q?dwXLwr+1dSaRo5FB158oHzMb0SQhCcy6C0K+uwnsgVR/9jimMK21sHvN?= =?Windows-1252?Q?tLCPcl7Ski+VlXiLiR1+kfEhOQN2WcThZ2EcdS/3HbJuDkqjVyPzHoru?= =?Windows-1252?Q?hPD4qEemvuSCAarlpY8EaUpOiDQ2L73BgEB4KTzbjzXNWgi2BDqLQD7U?= =?Windows-1252?Q?+1pChfKt1t7+F3eaLwYRpvlrpjLfjVscp5SmmONruZYyTr8af5VCrt5d?= =?Windows-1252?Q?MUvNq1H5nRzajXpt2LcIv05mzEu22xcGd3tKi276v2NEPMRTKpszszBx?= =?Windows-1252?Q?aqz2hL9ZfdY+pnLl9qPRmOBsUd1oo5iJzgLTYAySGzf41Z5dRgPpMvUu?= =?Windows-1252?Q?g63g99xpTQWLkY7oINYBWGPASApTFb621hxdSeORmVqY65QOYNZIiWfO?= =?Windows-1252?Q?qYIp4gw556DlVakHulHUzMuO/En3p7LyimDzFx2EJEjEipuGH0aF4UPj?= =?Windows-1252?Q?fPe9XATb5i1niC8lfKcxuoW5yUf4YT4njiMaWF5+x78+RsOqB3K6WQhb?= =?Windows-1252?Q?vEDD7gIqkHBnGrQriQqSem0EeT0T/ib1kWieeaxrFJyVZdlNr5n+uWb6?= =?Windows-1252?Q?zUhZQN0HnYy689sOkSCwhiuhL/KtoeGpiGYC/sHSaM02trVgZ3znbw2n?= =?Windows-1252?Q?56qTuEBWjIQtdRr1M4nljISiDs2Kr9sHqU6CSJ+aWGnaz6+LoimuND7N?= =?Windows-1252?Q?KbuXiSoEVVWwwbIG+uOTNQh7L6NE8aQoi8hKJS/ziEkQ80FYC1zK9Jrs?= =?Windows-1252?Q?+n/miHOuniz5unjvXUhzrKnZ47rXI5O2Cvvvo0lY/C1+2Q12ypmPRCtF?= =?Windows-1252?Q?K2itSvk3ehLLJ9a63633k4lk+kX6XRUxWZ+m6LUKMFKi/LKaylS03g15?= =?Windows-1252?Q?7fr9Gwugg5mGcU92M3d9W6OZN4mSkhsMszQP3Gwdy0eKCFb1qeYkJJDH?= =?Windows-1252?Q?pdb3hz94o5RfXwacZFLpK0glb7lqcwJlmJUQhNF/jWpYI?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1706;6:HtW/11LAJqK0ed/3STPrHPLeUGy1nBs/Z3OXKYbK+SNmJh50E62bgnK36T1wSOTMmfR+IFLy/rVQ8CahTCTo012eRaqI3oltE3V5/pm26wm6odYVWDJ+kQk1Ktd+0I5E10ENDOFdgRU5GF8UnvJNgSd7ByiouSwcCPrbBsX7rlQDaIwobN/8EVHCp7VcBEoKTOpfaaFG7qZGiSBjqnsOmnaCFySfvSj9+5x9VpmJ8KIGv/+HdgkyLiOFULpGXS6SQ499A1Fd5fMK01AGMzWjCyoy8xqyvglAlLPqZTxu8GfcdoxZMf4BaQSbKgqJDKtY2NyGcJ8/YQ2SPzBXhV6jFIkBa0HIpO1Jfa4DhyOJBFCSDoyikonrlVSmUogBZ6TxFcxpkMBOgSSpbSdO+xdy4XlOYYydfOmsiMzbkJymJ5I=;5:wqScKrOtsMsHGENKGrA3alC7GK7jMeWqpJcJ3VJ3oFvtG4Tk4uQ7I4BaLV7ylmQFyJOqTsOJpP+riIDXfEwgNaZ4L68K409S2feCF1Vk5WY9OWcu4nubIVsJ1HZ2mcSllvuOE0vg81CNFQwG8anJ/gdJeeQxjaEklgXtkRvlLo0=;24:/F8SuPazoAVcIii9d0hBMEBZ3nKDx+xJF2vPvrfDg1Cdv7FXyDz0b73CVg4EksYEbRpj5ETzenflTNdResgZQl0xEN4iBPtJo57viXFWZvE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1706;7:BKhw0/BqqDC5JVTWkOQ5MJhayd72MBnim+7lItK/O1LEllI9GetDtBwJrCSrAFQiKAk5pRRgV3Ye1fSIu6D4JLBZXbJim49BPFyRlo009QWCDH7pa0j7DWOH+X6ly65ucfiqThGbyK63D0D1xgpAz2JKqmIGnB5h9NEMtodNWVorTo38XK/Dex6qvqvCSv0Q/jRenJPonlbP8bzh+03UCl4PO13ZJ0qCUyKU6g9j9CDKPWM5TuMF+30Y2pQiuJmTTpi+zzvejiiuwQgovKXWJD9d+DCP86BykVZUTBdWVSc/+ssvJkdcQ7MKKF8s2i9LEcf6k1XbHkiZQeGt/c+lJtUO0g7r+laxy7Uuxm1GkZhYeBrMv0wTVBSvfm0PbClv1SwEKgYljz33Wi/FwQjyEp1tG8/tD/jS+DUmYXMUvaqVi2APjZq7e4SmujMc0Q1aYTywNdjLE5fwE+Ph+M95Ww== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 11:21:33.6562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1706 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephan, Thank you for the clarification. Regards, -George On 01/12/2017 04:49 PM, Stephan Müller wrote: > Am Donnerstag, 12. Januar 2017, 16:40:32 CET schrieb George Cherian: > > Hi George, > >>> >>> Sure, please do not forget to invoke xts_verify_key. >> >> Should I be using xts_check_key or xts_verify_key? > > Both are identical except for the input parameter -- the one requires > crypto_skcipher, the other crypto_tfm. Depending what pointer you have handy > in your setkey function, you would use the most appropriate one. > > Ciao > Stephan >