From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbdALRv2 (ORCPT ); Thu, 12 Jan 2017 12:51:28 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:10297 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdALRuU (ORCPT ); Thu, 12 Jan 2017 12:50:20 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 11 Jan 2017 21:45:31 -0800 Message-ID: <5877BE49.2010008@nvidia.com> Date: Thu, 12 Jan 2017 23:05:05 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Thierry Reding CC: Sebastian Reichel , Martin Michlmayr , , , Chaitanya Bandi Subject: Re: [PATCH] power: reset: Add MAX77620 support References: <20170112161507.23774-1-thierry.reding@gmail.com> <5877B088.5040007@nvidia.com> <20170112173513.GA22794@ulmo.ba.sec> In-Reply-To: <20170112173513.GA22794@ulmo.ba.sec> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 January 2017 11:05 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Jan 12, 2017 at 10:06:24PM +0530, Laxman Dewangan wrote: >> On Thursday 12 January 2017 09:45 PM, Thierry Reding wrote: >>> >>> + dev_dbg(&pdev->dev, "event recorder: %#x\n", value); >>> + >>> + system_power_controller = power; >>> + pm_power_off = max77620_pm_power_off; >>> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) >>> + arm_pm_restart = max77620_pm_restart; >> What if we want to reset via the Tegra and not through PMIC? > In that case I assume we either don't have a PMIC, or we should not add > the system-power-controller device tree property to the PMIC node. In > the latter case this driver won't install any power off or restart > callbacks. We need reset from Tegra and power of from PMIC. Tegra does not support power OFF.